Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Make return value order of quadtree_point_to_nearest_polyline match quadtree_point_in_polygon #491

Open
harrism opened this issue Feb 15, 2022 · 4 comments
Labels
feature request New feature or request Needs Triage Need team to review and classify

Comments

@harrism
Copy link
Member

harrism commented Feb 15, 2022

In fixing #489 we noticed the following.

cuspatial::quadtree_point_in_polygon returns two values: offsets of polygons, then offsets of points.

* @return A cudf table with two columns, where each row represents a point/polygon intersection:
* polygon_offset - UINT32 column of polygon indices
* point_offset - UINT32 column of point indices

cuspatial::quadtree_point_to_nearest_polyline returns these in the opposite order. (point offset then polyline offset)

* @return A cudf table with three columns, where each row represents a point/polyline pair and the
* distance between the two:
*
* point_offset - UINT32 column of point indices
* polyline_offset - UINT32 column of polyline indices
* distance - FLOAT or DOUBLE column (based on input point data type) of distances between
* each point and polyline

We should make the order match, or adopt structured data with named fields, which could be done as a part of an API refactor to remove dependency on libcudf (#474).

CC @trxcllnt

@harrism harrism added feature request New feature or request Needs Triage Need team to review and classify labels Feb 15, 2022
@github-actions
Copy link

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@github-actions
Copy link

This issue has been labeled inactive-90d due to no recent activity in the past 90 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.

@harrism
Copy link
Member Author

harrism commented Aug 1, 2022

@trxcllnt would you be able to knock this out while adding the header-only API?

@github-actions
Copy link

github-actions bot commented Sep 1, 2022

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request Needs Triage Need team to review and classify
Projects
Status: Todo
Development

No branches or pull requests

2 participants