Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA][JNI] ContiguousTable.getBuffer should increase ref count of buffer #17566

Open
abellina opened this issue Dec 10, 2024 · 0 comments
Open
Labels
feature request New feature or request Java Affects Java cuDF API.

Comments

@abellina
Copy link
Contributor

We currently have a class in JNI called ContiguousTable which tracks both a contiguous device memory buffer and metadata needed to recreate a cuDF table from it. These are the results of contiguous_split.

The problem is that right now we have code in the plugin that calls getBuffer on this object and then has to remember to increase ref counts, or otherwise be really careful about handling this buffer since it goes away once the ContiguousTable closes.

It would be nice to fix this so we can clean up code in the plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request Java Affects Java cuDF API.
Projects
None yet
Development

No branches or pull requests

1 participant