Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] libcudf should depend on Jitify2 branch, not custom fork #10654

Closed
cwharris opened this issue Apr 13, 2022 · 4 comments
Closed

[BUG] libcudf should depend on Jitify2 branch, not custom fork #10654

cwharris opened this issue Apr 13, 2022 · 4 comments
Labels
CMake CMake build issue improvement Improvement / enhancement to an existing function

Comments

@cwharris
Copy link
Contributor

libcudf jitify2 source should be changed from our custom fork to a specific commit of the @NVIDIA/jitify jitify2 branch. Which commit should be used is in question.

cudf/cpp/cmake/thirdparty/get_jitify.cmake

Lines 21 to 22 in ce56bc3

GIT_REPOSITORY https://github.com/rapidsai/jitify.git
GIT_TAG cudf_0.19

@cwharris cwharris added Needs Triage Need team to review and classify tech debt improvement Improvement / enhancement to an existing function labels Apr 13, 2022
@cwharris
Copy link
Contributor Author

This should wait until after jifity2 removes it's dependency on libcuda.so

@github-actions
Copy link

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@GregoryKimball GregoryKimball added CMake CMake build issue and removed Needs Triage Need team to review and classify labels Jun 28, 2022
@shwina shwina mentioned this issue Jul 18, 2022
Merged
@shwina
Copy link
Contributor

shwina commented Jul 18, 2022

We're currently blocked by the folllowing jitify2 issue: NVIDIA/jitify#107

@shwina
Copy link
Contributor

shwina commented Aug 29, 2022

Closed in #11287

@shwina shwina closed this as completed Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CMake CMake build issue improvement Improvement / enhancement to an existing function
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cwharris @shwina @GregoryKimball