Skip to content

Commit 4591523

Browse files
committed
Deprecate cudf::grouped_time_range_rolling_window
Since the range-based rolling window APIs were extended to support any orderable column (rather than just time-based windows), this function has been a thin forwarding wrapper to cudf::grouped_range_rolling_window. It could have been deprecated at the time, but was not. It seems there are no usages outside of the libcudf test suite. Partially addresses #13050.
1 parent becfacc commit 4591523

File tree

4 files changed

+655
-580
lines changed

4 files changed

+655
-580
lines changed

cpp/include/cudf/rolling.hpp

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616

1717
#pragma once
1818

19+
#include <cudf/aggregation.hpp>
1920
#include <cudf/rolling/range_window_bounds.hpp>
2021
#include <cudf/types.hpp>
2122
#include <cudf/utilities/export.hpp>
@@ -322,6 +323,8 @@ std::unique_ptr<column> grouped_rolling_window(
322323
* @brief Applies a grouping-aware, timestamp-based rolling window function to the values in a
323324
* column.
324325
*
326+
* @deprecated Since 25.02, to be removed in 25.04
327+
*
325328
* Like `rolling_window()`, this function aggregates values in a window around each
326329
* element of a specified `input` column. It differs from `rolling_window()` in two respects:
327330
* 1. The elements of the `input` column are grouped into distinct groups (e.g. the result of a
@@ -403,7 +406,8 @@ std::unique_ptr<column> grouped_rolling_window(
403406
*
404407
* @returns A nullable output column containing the rolling window results
405408
*/
406-
std::unique_ptr<column> grouped_time_range_rolling_window(
409+
[[deprecated("Use cudf::grouped_range_rolling_window instead")]] std::unique_ptr<column>
410+
grouped_time_range_rolling_window(
407411
table_view const& group_keys,
408412
column_view const& timestamp_column,
409413
cudf::order const& timestamp_order,
@@ -419,6 +423,8 @@ std::unique_ptr<column> grouped_time_range_rolling_window(
419423
* @brief Applies a grouping-aware, timestamp-based rolling window function to the values in a
420424
* column,.
421425
*
426+
* @deprecated Since 25.02, to be removed in 25.04
427+
*
422428
* @details @copydetails grouped_time_range_rolling_window(
423429
* table_view const& group_keys,
424430
* column_view const& timestamp_column,
@@ -434,7 +440,8 @@ std::unique_ptr<column> grouped_time_range_rolling_window(
434440
* The `preceding_window_in_days` and `following_window_in_days` are specified as a `window_bounds`
435441
* and supports "unbounded" windows, if set to `window_bounds::unbounded()`.
436442
*/
437-
std::unique_ptr<column> grouped_time_range_rolling_window(
443+
[[deprecated("Use cudf::grouped_range_rolling_window instead")]] std::unique_ptr<column>
444+
grouped_time_range_rolling_window(
438445
table_view const& group_keys,
439446
column_view const& timestamp_column,
440447
cudf::order const& timestamp_order,

0 commit comments

Comments
 (0)