New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logic weirdness in summarizers `isKind` #359

Open

andreas-kupries opened this issue Jan 29, 2024 · 0 comments

andreas-kupries commented Jan 29, 2024

The piece of code at
https://github.com/rancher/wrangler/blob/master/pkg/summary/summarizers.go#L422-L428
is weird.

The return in line 423 preempts the block at 426-428.

I suspect that the return in line 423 is ok, allowing the block 426-428 to be reduced to just line 427.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment