Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark invalid snapshots as obsolete #720

Open
alexander-demicev opened this issue Sep 4, 2024 · 1 comment
Open

Mark invalid snapshots as obsolete #720

alexander-demicev opened this issue Sep 4, 2024 · 1 comment
Assignees
@vatsalparekh
Labels
area/etcdsnapshot-restore Categorizes issue or PR as related to Turtles ETCD Snapshot & Restore feature kind/enhancement Categorizes issue or PR as related to a new feature.

Comments

@alexander-demicev
Copy link
Member

alexander-demicev commented Sep 4, 2024 •
edited
Loading

We need to mark invalid as obsolete and prevent using obsolete snapshots when performing a restore. The snapshot is obsolete when:

  • cluster version is different from when the snapshot was made
  • cluster configuration changed(RKE2ControlPlane.Spec or RKE2ConfigTemplate.Spec)
  • cluster the snapshot was made for doesn't exist anymore
  • RKE2 control plane replicas didn't change
@alexander-demicev alexander-demicev added the area/etcdsnapshot-restore Categorizes issue or PR as related to Turtles ETCD Snapshot & Restore feature label Sep 4, 2024
@alexander-demicev alexander-demicev self-assigned this Sep 5, 2024
@alexander-demicev alexander-demicev moved this from CAPI Backlog to In Progress (8 max) in CAPI & Hosted Kubernetes providers (EKS/AKS/GKE) Sep 5, 2024
@alexander-demicev alexander-demicev removed their assignment Sep 5, 2024
@vatsalparekh vatsalparekh self-assigned this Nov 11, 2024
@kkaempf kkaempf added the kind/enhancement Categorizes issue or PR as related to a new feature. label Nov 12, 2024
@Danil-Grigorev
Copy link
Contributor

I think last point is already fixed by implementing #841 which maintains up-to-date list of snapshots.

  • cluster the snapshot was made for doesn't exist anymore

@alexander-demicev alexander-demicev moved this from CAPI Backlog to In Progress (8 max) in CAPI & Hosted Kubernetes providers (EKS/AKS/GKE) Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vatsalparekh vatsalparekh

Labels
area/etcdsnapshot-restore Categorizes issue or PR as related to Turtles ETCD Snapshot & Restore feature kind/enhancement Categorizes issue or PR as related to a new feature.
Projects
CAPI & Hosted Kubernetes providers (EKS/AKS/GKE)
Status: In Progress (8 max)
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kkaempf @vatsalparekh @alexander-demicev @Danil-Grigorev