Skip to content
This repository was archived by the owner on Aug 3, 2020. It is now read-only.

Commit bd46128

Browse files
author
Alena Prokharchyk
authored
Merge pull request #13 from alena1108/ipback
InternalIpAddress back
2 parents a2fd0c6 + d5ad258 commit bd46128

File tree

2 files changed

+18
-7
lines changed

2 files changed

+18
-7
lines changed

rancher/rancher.go

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -658,6 +658,10 @@ func (r *CloudProvider) NodeAddresses(nodeName types.NodeName) ([]api.NodeAddres
658658
Type: api.NodeExternalIP,
659659
Address: ip.Address,
660660
})
661+
addresses = append(addresses, api.NodeAddress{
662+
Type: api.NodeInternalIP,
663+
Address: ip.Address,
664+
})
661665
}
662666

663667
addresses = append(addresses, api.NodeAddress{
@@ -868,7 +872,10 @@ func (r *CloudProvider) getHostByName(name string) (*Host, error) {
868872

869873
// GetZone is an implementation of Zones.GetZone
870874
func (r *CloudProvider) GetZone() (cloudprovider.Zone, error) {
871-
return cloudprovider.Zone{}, errors.New("unimplemented")
875+
return cloudprovider.Zone{
876+
FailureDomain: "FailureDomain1",
877+
Region: "Region1",
878+
}, nil
872879
}
873880

874881
// --- Utility functions ---

rancher/rancher_test.go

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -537,16 +537,20 @@ func TestNodeAddresses(t *testing.T) {
537537

538538
addresses, err := cloudProvider.NodeAddresses("test2")
539539

540-
if len(addresses) != 3 {
541-
t.Errorf("expected 3 addresses, found, [%+v], err: [%v]", addresses, err)
540+
if len(addresses) != 5 {
541+
t.Errorf("expected 5 addresses, found, [%+v], err: [%v]", addresses, err)
542542
}
543543

544-
if addresses[1].Type != api.NodeExternalIP || addresses[1].Address != "192.168.1.1" {
545-
t.Errorf("expected address 1 to be 192.168.1.1, found %s", addresses[1].Address)
544+
if addresses[2].Type != api.NodeExternalIP || addresses[2].Address != "192.168.1.1" {
545+
t.Errorf("expected address 0 to be 192.168.1.1, found %s", addresses[2].Address)
546546
}
547547

548-
if addresses[2].Type != api.NodeHostName || addresses[2].Address != "test2" {
549-
t.Errorf("expected address 2 to be test2, found %s", addresses[2].Address)
548+
if addresses[3].Type != api.NodeInternalIP || addresses[3].Address != "192.168.1.1" {
549+
t.Errorf("expected address 1 to be 192.168.1.1, found %s", addresses[3].Address)
550+
}
551+
552+
if addresses[4].Type != api.NodeHostName || addresses[4].Address != "test2" {
553+
t.Errorf("expected address 2 to be test2, found %s", addresses[4].Address)
550554
}
551555
}
552556

0 commit comments

Comments
 (0)