-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating Ports with correctDrift enabled using multiple-paths repo triggers an error #2609
Comments
Not sure if the Modified state is somehow related to rancher/dashboard#11404 |
I just performed a manual check and it seems there was a caveat in our automation. I will keep investigating tomorrow morning |
Seems related to how helm upgrades services for us. See fleet-agent should store the error in the bundledeployments status |
Adding error logs {
"level": "error",
"ts": "2024-07-10T09:02:36Z",
"logger": "bundledeployment",
"msg": "Failed to deploy bundle",
"controller": "bundledeployment",
"controllerGroup": "fleet.cattle.io",
"controllerKind": "BundleDeployment",
"BundleDeployment": {
"name": "test-drift-multiple-paths-service",
"namespace": "cluster-fleet-default-imported-2-945038eba7ea"
},
"namespace": "cluster-fleet-default-imported-2-945038eba7ea",
"name": "test-drift-multiple-paths-service",
"reconcileID": "308f9b4f-fb0f-48ca-a273-2e475b183966",
"status": {
"conditions": [
{
"type": "Installed",
"status": "True",
"lastUpdateTime": "2024-07-10T09:01:20Z"
},
{
"type": "Deployed",
"status": "False",
"lastUpdateTime": "2024-07-10T09:02:36Z",
"reason": "Error",
"message": "cannot patch \"mp-app-service\" with kind Service: Service \"mp-app-service\" is invalid: spec.ports[1].name: Duplicate value: \"required-name2\""
},
{
"type": "Ready",
"status": "True",
"lastUpdateTime": "2024-07-10T09:02:36Z"
},
{
"type": "Monitored",
"status": "True",
"lastUpdateTime": "2024-07-10T09:01:20Z"
}
],
"appliedDeploymentID": "s-e900fb60b86d8593e95a733a0c0d1794f2d71a00910f794d19bcd4d57deca:aa73273923fd2b194b95dc51be330a7b1be92dafa689e0afb400abda8b37d8c0",
"release": "test-fleet-mp-service/test-drift-multiple-paths-service:1",
"ready": true,
"nonModified": true,
"display": {
"deployed": "Error: cannot patch \"mp-app-service\" with kind Service: Service \"mp-app-service\" is invalid: spec.ports[1].name: Duplicate value: \"required-name2\"",
"monitored": "True",
"state": "Ready"
},
"syncGeneration": 0
},
"error": "cannot patch \"mp-app-service\" with kind Service: Service \"mp-app-service\" is invalid: spec.ports[1].name: Duplicate value: \"required-name2\"",
"errorVerbose": "cannot patch \"mp-app-service\" with kind Service: Service \"mp-app-service\" is invalid: spec.ports[1].name: Duplicate value: \"required-name2\"\nhelm.sh/helm/v3/pkg/kube.(*Client).Update\n\t/home/runner/go/pkg/mod/github.com/rancher/helm/[email protected]/pkg/kube/client.go:438\nhelm.sh/helm/v3/pkg/action.(*Install).performInstall\n\t/home/runner/go/pkg/mod/github.com/rancher/helm/[email protected]/pkg/action/install.go:456\nhelm.sh/helm/v3/pkg/action.(*Install).performInstallCtx.func1\n\t/home/runner/go/pkg/mod/github.com/rancher/helm/[email protected]/pkg/action/install.go:421\nruntime.goexit\n\t/home/runner/go/pkg/mod/golang.org/[email protected]/src/runtime/asm_amd64.s:1695",
"stacktrace": "github.com/rancher/fleet/internal/cmd/agent/controller.(*BundleDeploymentReconciler).Reconcile\n\t/home/runner/work/fleet/fleet/internal/cmd/agent/controller/bundledeployment_controller.go:129\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile\n\t/home/runner/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:114\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/home/runner/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:311\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/home/runner/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:261\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/home/runner/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:222"
}
{
"level": "error",
"ts": "2024-07-10T09:02:36Z",
"msg": "Reconciler error",
"controller": "bundledeployment",
"controllerGroup": "fleet.cattle.io",
"controllerKind": "BundleDeployment",
"BundleDeployment": {
"name": "test-drift-multiple-paths-service",
"namespace": "cluster-fleet-default-imported-2-945038eba7ea"
},
"namespace": "cluster-fleet-default-imported-2-945038eba7ea",
"name": "test-drift-multiple-paths-service",
"reconcileID": "308f9b4f-fb0f-48ca-a273-2e475b183966",
"error": "failed deploying bundle: cannot patch \"mp-app-service\" with kind Service: Service \"mp-app-service\" is invalid: spec.ports[1].name: Duplicate value: \"required-name2\"",
"errorCauses": [
{
"error": "failed deploying bundle: cannot patch \"mp-app-service\" with kind Service: Service \"mp-app-service\" is invalid: spec.ports[1].name: Duplicate value: \"required-name2\""
}
],
"stacktrace": "sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/home/runner/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:324\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/home/runner/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:261\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/home/runner/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:222"
} |
Additional QAProblemWhen failing to correct drift on a resource (eg. modified ports array on a service), Fleet would leave a Solution
TestingSee reproduction steps above, in the issue description. Engineering TestingManual Testing
Automated Testing
QA Testing Considerations
Regressions ConsiderationsN/A |
Issue
Error triggered after updating ports with correctDrift enabled while using multiple-paths repo
Reproduction steps
2.8.5
+.2.8-head
but not in2.9.0-alpha7
Edit: Observed in 2.9 as well IF
Force update
is appliedThis check has been currently added to ui/e2e ci here. A video can be downloaded from artifact and can by playing the part p1.specs.ts on minute 8:02
The text was updated successfully, but these errors were encountered: