Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RKE2Config support for MachinePools #569

Open
anmazzotti opened this issue Feb 6, 2025 · 0 comments
Open

RKE2Config support for MachinePools #569

anmazzotti opened this issue Feb 6, 2025 · 0 comments
Assignees
Labels
kind/feature New feature or request needs-priority Indicates an issue or PR needs a priority assigning to it needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@anmazzotti
Copy link
Contributor

Describe the solution you'd like:
Currently the bootstrap controller expects a RKE2Config owned by a Machine.
However, when referenced by a MachinePool, the owner will be the MachinePool itself.

For example:

apiVersion: cluster.x-k8s.io/v1beta1
kind: MachinePool
metadata:
  name: capi-machinepool-mp-0
  namespace: default
spec:
  clusterName: capi-machinepool
  replicas: 3
  template:
    spec:
      bootstrap:
        configRef:
          apiVersion: bootstrap.cluster.x-k8s.io/v1beta1
          kind: RKE2Config
          name: capi-machinepool-mp-0
apiVersion: bootstrap.cluster.x-k8s.io/v1beta1
kind: RKE2Config
metadata:
  labels:
    cluster.x-k8s.io/cluster-name: capi-machinepool
  name: capi-machinepool-mp-0
  namespace: default
  ownerReferences:
    - apiVersion: cluster.x-k8s.io/v1beta1
      blockOwnerDeletion: true
      controller: true
      kind: MachinePool
      name: capi-machinepool-mp-0
      uid: 0d99ccb9-80d6-4842-b1de-0a6f9b05d7c5
spec:
  agentConfig:
    additionalUserData: {}
    format: cloud-config
  privateRegistriesConfig: {}

Also be aware that the kubeadm implementation does take special actions when the config is owner by a MachinePool.
Possibly this applies to RKE2 as well.

Why do you want this feature:

RKE2 support for MachinePools

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

@anmazzotti anmazzotti added kind/feature New feature or request needs-priority Indicates an issue or PR needs a priority assigning to it needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 6, 2025
@alexander-demicev alexander-demicev moved this to Team Backlog in CAPI / Turtles Feb 18, 2025
@anmazzotti anmazzotti self-assigned this Feb 21, 2025
@anmazzotti anmazzotti moved this from Team Backlog to In Progress (8 max) in CAPI / Turtles Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request needs-priority Indicates an issue or PR needs a priority assigning to it needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
Status: In Progress (8 max)
Development

No branches or pull requests

1 participant