Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need for RKE2ControlPlane status.version field to support MachineSetPreflightChecks #478

Open
tmmorin opened this issue Oct 22, 2024 · 0 comments
Labels
kind/feature New feature or request needs-priority Indicates an issue or PR needs a priority assigning to it needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@tmmorin
Copy link

tmmorin commented Oct 22, 2024

Describe the solution you'd like:

In the context of Sylva project, we need to use MachineSetPreflightChecks and RKE2ControlPlane is missing a status.version to satisfy the Cluster API contract needed to use MachineSetPreflightChecks.

https://cluster-api.sigs.k8s.io/tasks/experimental-features/machineset-preflight-checks

Why do you want this feature:

MachineSetPreflightChecks are needed to ensure that we can satisfy Kubernetes version skew constraints while upgrading a cluster (upgrading the control plane before MachineDeployments).

Details:

// IsUpgrading returns true if the control plane is in the middle of an upgrade, false otherwise.
// A control plane is considered upgrading if:
// - if spec.version is greater than status.version.
	// We can know if the control plane was previously created or is being cretaed for the first
	// time by looking at controlplane.status.version. If the version in status is set to a valid
	// value then the control plane was already provisioned at a previous time. If not, we can
	// assume that the control plane is being created for the first time.

References

Sylva issue https://gitlab.com/sylva-projects/sylva-core/-/issues/1658

@tmmorin tmmorin added kind/feature New feature or request needs-priority Indicates an issue or PR needs a priority assigning to it needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 22, 2024
@tmmorin tmmorin changed the title need to support Machine need for RKE2ControlPlane status.version field to support MachineSetPreflightChecks Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request needs-priority Indicates an issue or PR needs a priority assigning to it needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

No branches or pull requests

1 participant