need for RKE2ControlPlane status.version field to support MachineSetPreflightChecks #478
Labels
kind/feature
New feature or request
needs-priority
Indicates an issue or PR needs a priority assigning to it
needs-triage
Indicates an issue or PR lacks a `triage/foo` label and requires one.
Describe the solution you'd like:
In the context of Sylva project, we need to use MachineSetPreflightChecks and RKE2ControlPlane is missing a
status.version
to satisfy the Cluster API contract needed to use MachineSetPreflightChecks.https://cluster-api.sigs.k8s.io/tasks/experimental-features/machineset-preflight-checks
Why do you want this feature:
MachineSetPreflightChecks are needed to ensure that we can satisfy Kubernetes version skew constraints while upgrading a cluster (upgrading the control plane before MachineDeployments).
Details:
https://github.com/kubernetes-sigs/cluster-api/blob/c3ae478440996666f015288367b59d802fd50d92/internal/controllers/machineset/machineset_preflight.go#L150
https://github.com/kubernetes-sigs/cluster-api/blob/c3ae478440996666f015288367b59d802fd50d92/internal/contract/controlplane.go#L175
References
Sylva issue https://gitlab.com/sylva-projects/sylva-core/-/issues/1658
The text was updated successfully, but these errors were encountered: