Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RKE2 control plane machines should be adopted after restore #200

Open
raafatseif opened this issue Nov 16, 2023 · 0 comments
Open

RKE2 control plane machines should be adopted after restore #200

raafatseif opened this issue Nov 16, 2023 · 0 comments
Labels
kind/bug Something isn't working priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@raafatseif
Copy link

What happened:
RKE2 control plane controller does not adopt the control-plane machines by adding back the ownerReferences after restore using velero. This causes the control plane resource to get stuck in inactive status and not responsive to changes such as scaling up/down control plane machines.

What did you expect to happen:
Control plane cluster api Machines are adopted by the RKE2 control plane after velero restore.

How to reproduce it:

  1. Create a workload cluster with rke2 control plane on management cluster
  2. Create a backup of the cluster api resources using velero
  3. Rebuild the management cluster
  4. Restore the cluster api resources using velero

Anything else you would like to add:
Related pull request based on kubeadm kubernetes-sigs/cluster-api#7591

Environment:

  • rke provider version: v0.1.1
  • Kubernetes version: v1.24.12+rke2r1
  • OS (e.g. from /etc/os-release): Alpine Linux v3.18
@raafatseif raafatseif added kind/bug Something isn't working needs-priority Indicates an issue or PR needs a priority assigning to it needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 16, 2023
@alexander-demicev alexander-demicev added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates an issue or PR needs a priority assigning to it needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Something isn't working priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexander-demicev @raafatseif