removing unnecessary function

Author: nicholasSUSE

pkg/lifecycle/parser.go

@@ -3,10 +3,8 @@ package lifecycle
 import (
 	"context"
 	"fmt"
-	"sort"
 	"strings"
 
-	"github.com/Masterminds/semver"
 	"github.com/go-git/go-billy/v5"
 	helmRepo "helm.sh/helm/v3/pkg/repo"
 )
@@ -103,19 +101,3 @@ func (ld *Dependencies) populateAssetsVersionsPath(ctx context.Context) error {
 	// Now fileNames slice contains the names of all files in the directories
 	return nil
 }
-
-// sortAssetsVersions will convert to semver and
-// sort the assets for each key in the assetsVersionsMap
-func (ld *Dependencies) sortAssetsVersions() {
-	// Iterate over the map and sort the assets for each key
-	for k, assets := range ld.AssetsVersionsMap {
-		sort.Slice(assets, func(i, j int) bool {
-			vi, _ := semver.NewVersion(assets[i].Version)
-			vj, _ := semver.NewVersion(assets[j].Version)
-			return vi.LessThan(vj)
-		})
-		ld.AssetsVersionsMap[k] = assets
-	}
-
-	return
-}

pkg/lifecycle/parser_test.go

@@ -106,34 +106,3 @@ func Test_populateAssetsVersionsPath(t *testing.T) {
 		assert.Error(t, err, "populateAssetsVersionsPath should have returned an error")
 	})
 }
-
-func Test_sortAssetsVersions(t *testing.T) {
-	// Arrange
-	dependency := &Dependencies{
-		AssetsVersionsMap: map[string][]Asset{
-			"chart1": {
-				{Version: "1.0.0"},
-				{Version: "0.1.0"},
-				{Version: "0.0.1"},
-			},
-			"chart2": {
-				{Version: "2.0.0"},
-				{Version: "1.1.0"},
-				{Version: "1.0.1"},
-			},
-		},
-	}
-
-	// Act
-	dependency.sortAssetsVersions()
-
-	// Assertions
-	assert.Equal(t, len(dependency.AssetsVersionsMap), 2, "Expected 2 charts in the assetsVersionsMap")
-	assert.Equal(t, dependency.AssetsVersionsMap["chart1"][0].Version, "0.0.1", "Expected 0.0.1")
-	assert.Equal(t, dependency.AssetsVersionsMap["chart1"][1].Version, "0.1.0", "Expected 0.1.0")
-	assert.Equal(t, dependency.AssetsVersionsMap["chart1"][2].Version, "1.0.0", "Expected 1.0.0")
-
-	assert.Equal(t, dependency.AssetsVersionsMap["chart2"][0].Version, "1.0.1", "Expected 1.0.1")
-	assert.Equal(t, dependency.AssetsVersionsMap["chart2"][1].Version, "1.1.0", "Expected 1.1.0")
-	assert.Equal(t, dependency.AssetsVersionsMap["chart2"][2].Version, "2.0.0", "Expected 2.0.0")
-}