Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider tokio::task::JoinSet for parallel computation #216

Open
ralexstokes opened this issue Apr 20, 2024 · 1 comment
Open

Consider tokio::task::JoinSet for parallel computation #216

ralexstokes opened this issue Apr 20, 2024 · 1 comment
Labels
good first issue Good for newcomers

Comments

@ralexstokes
Copy link
Owner

.buffer_unordered(self.relays.len())

We likely want to use JoinSet here and anywhere we use this type of pattern for parallelism. The current implementation provides concurrency within one thread but I think this means we are leaving some performance on the table...

@ralexstokes ralexstokes added the good first issue Good for newcomers label Apr 20, 2024
@Gerson2102
Copy link

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I'm a junior software developer from the Dojo Coding community with contributions to several OnlyDust projects. Including Madara, Cairo native, kakarot-rpc, and Giza. All the projects where I contributed are in Rust, so I have been dealing with this language for a while. You can check my OD profile here: https://app.onlydust.com/u/Gerson2102

How I plan on tackling this issue

This is my first time seeing this project in OD. And it can be my first contribution to the project. I will start by understanding the code related to the issue. If I'm too stuck in this, i will ask questions in your telegram group if you guys have one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants