From 759e625ae83abca4c86b17ec44f381bd89d1547c Mon Sep 17 00:00:00 2001 From: Alex Stokes Date: Wed, 1 May 2024 08:51:21 -0600 Subject: [PATCH 1/2] add some docs --- mev-rs/src/types/auction_request.rs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/mev-rs/src/types/auction_request.rs b/mev-rs/src/types/auction_request.rs index 00718ef0..09bb4a08 100644 --- a/mev-rs/src/types/auction_request.rs +++ b/mev-rs/src/types/auction_request.rs @@ -1,11 +1,15 @@ use ethereum_consensus::primitives::{BlsPublicKey, Hash32, Slot}; +/// Describes a single unique auction. #[derive(Debug, Default, Clone, PartialEq, Eq, Hash)] #[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))] pub struct AuctionRequest { + /// Slot for the proposal #[serde(with = "crate::serde::as_str")] pub slot: Slot, + /// Hash of the parent block for the proposal pub parent_hash: Hash32, + /// Public key of the proposer for the proposal pub public_key: BlsPublicKey, } From cabe308a7c72ec07019d3346db945d304e7e1db7 Mon Sep 17 00:00:00 2001 From: Alex Stokes Date: Wed, 1 May 2024 08:51:27 -0600 Subject: [PATCH 2/2] clean up stale todo comments --- mev-boost-rs/src/relay_mux.rs | 1 - 1 file changed, 1 deletion(-) diff --git a/mev-boost-rs/src/relay_mux.rs b/mev-boost-rs/src/relay_mux.rs index decb428d..287fd1ee 100644 --- a/mev-boost-rs/src/relay_mux.rs +++ b/mev-boost-rs/src/relay_mux.rs @@ -200,7 +200,6 @@ impl BlindedBlockProvider for RelayMux { return Err(Error::NoBidPrepared(auction_request.clone())) } - // TODO: change `value` so it does the copy internally let mut best_bid_indices = select_best_bids(bids.iter().map(|(_, bid)| bid.message.value()).enumerate());