Merge pull request #603 from brettz9/printUpgrades-return

Avoid variable suggesting a Promise is returned from `printUpgrades`

Author: raineorshine

lib/npm-check-updates.js

@@ -100,8 +100,10 @@ function createDependencyTable() {
 }
 
 /**
- * @param args.from
- * @param args.to
+ * @param {object} args
+ * @param {object} args.from
+ * @param {object} args.to
+ * @returns {Table}
  */
 function toDependencyTable(args) {
     const table = createDependencyTable();
@@ -144,7 +146,7 @@ function analyzeGlobalPackages(options) {
                     print(options, latest, 'silly');
 
                     const upgradedPackageNames = Object.keys(upgraded);
-                    const upgradePromise = printUpgrades(options, {
+                    printUpgrades(options, {
                         current: globalPackages,
                         upgraded,
                         latest,
@@ -164,8 +166,6 @@ function analyzeGlobalPackages(options) {
                     } else if (instruction.length) {
                         print(options, '\n' + chalk.cyan('ncu') + ' itself cannot upgrade global packages. Run the following to upgrade all global packages: \n\n' + chalk.cyan('npm -g install ' + instruction) + '\n');
                     }
-
-                    return upgradePromise;
                 });
         });
 }
@@ -255,6 +255,7 @@ function analyzeProjectDependencies(options, pkgData, pkgFile) {
  * @param {Object} args.upgraded - The packages that should be upgraded.
  * @param {number} args.numUpgraded - The number of upgraded packages
  * @param {number} args.total - The total number of all possible upgrades
+ * @returns {void}
  */
 function printUpgrades(options, {current, upgraded, numUpgraded, total}) {
     print(options, '');