This repository has been archived by the owner on Sep 13, 2020. It is now read-only.
Fix status icons paths #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@exentrich Would be good to get this merged. Are you still maintaining the project or would you consider opening up the maintainers list? |
|
@exentrich I would like to see this fixed as well. Let us know if more work needs to be done for this (eg. changing the version number). Thanks |
|
Sorry for late answer! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to an extra
/in the icon asset path, icons other than the default "idle" icon (which is defined separately in the manifest) do not render in Firefox. Chrome works OK - I think this is because Chrome strips out the extra/, whereas Firefox does not.Here is a log of the generated asset paths for the "saved" status icon:
This PR removes the extra
/in the string replacement operation, which renders the "saved" icon correctly when a URL is bookmarked:And here is the same log with the correct paths:
Fixes #31