Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Elements with role="dialog" or role="alertdialog" do not have accessible names. #2270

Closed
1 task done
mlenser opened this issue Dec 18, 2024 · 2 comments
Closed
1 task done

Comments

@mlenser
Copy link

mlenser commented Dec 18, 2024

Is there an existing issue for this?

  • I have searched the existing issues

RainbowKit Version

"@rainbow-me/rainbowkit": "^2.2.1",

wagmi Version

2.14.0

Current Behavior

wcm-modal does not have an accessible name according to Lighthouse.

wcm-modal likely comes from wallet connect and may need to be an issue on a dependent package

Expected Behavior

Lighthouse accessibility passes

Steps To Reproduce

Run lighthouse on an app with rainbowkit on web. https://www.rainbowkit.com for example will fail:
image

Link to Minimal Reproducible Example (CodeSandbox, StackBlitz, etc.)

https://www.rainbowkit.com

Anything else?

No response

@DanielSinclair
Copy link
Collaborator

That is upstream in WalletConnect correct. Have relayed to their team!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants