Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] <OKX Metamask link confusion> #2211

Closed
1 task done
LukeAntarctic opened this issue Oct 9, 2024 · 3 comments
Closed
1 task done

[bug] <OKX Metamask link confusion> #2211

LukeAntarctic opened this issue Oct 9, 2024 · 3 comments

Comments

@LukeAntarctic
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

RainbowKit Version

lastest

wagmi Version

lastest

Current Behavior

In the scenario where OKX is installed but Metamask is not installed, click on the link Metamask and let me link OKX. What I expect is to link Metamask, which can be implemented using this technique https://eips.ethereum.org/EIPS/eip-6963#abstract

Expected Behavior

No response

Steps To Reproduce

No response

Link to Minimal Reproducible Example (CodeSandbox, StackBlitz, etc.)

No response

Anything else?

No response
@LukeAntarctic
Copy link
Author

in https://www.rainbowkit.com/zh-CN/docs/introduction Can reproduce

@LukeAntarctic
Copy link
Author

@talentlessguy help plz

@DanielSinclair
Copy link
Collaborator

This is currently expected behavior. We rely on the MetaMask button as a fallback for all window.ethereum providers because this has historically been a common UI pattern.

@DanielSinclair DanielSinclair closed this as not planned Won't fix, can't repro, duplicate, stale Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@DanielSinclair @LukeAntarctic and others