chore: tree shake chain and account modals #2126
Closed
+80
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
1 task
|
lgtm! Don't think there's a better solution. Thanks |
|
@DanielSinclair any specific reason this was closed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Applied tree shaking for chain and account modals to prevent them from bundling when unused.
Screen recordings / screenshots
Here you can see that account and chain modals are bundled separately if they're being used.
tree-shaking-modals.mov
What to test
useAccountModalhook you shouldn't see account modal being bundled in network tab.useChainModalhook you shouldn't see chain modal being bundled in network tab.