chore: upgrade biome and simplify biome config (#1679)

* chore: upgrade biome to 1.4.1

* fix: safe fixes

* fix: ternary fomatting

* fix: typeof formatting

* fix: noUselessElse

* fix: align biome config with wevm

* fix: noForEach

Author: DanielSinclair

.pnpmfile.cjs

@@ -30,7 +30,7 @@ function omitRootDependencies(packageName, dependencies) {
     // None for now
   ];
 
-  Object.keys(dependencies).forEach((dep) => {
+  for (const dep of Object.keys(dependencies)) {
     if (!rootDependencies[dep] || allowedDuplicatePackages.includes(dep)) {
       // Keep the dependency in the app template's package.json since it's not in the
       // root package.json (or in the list of allowed duplicate packages).
@@ -46,7 +46,7 @@ function omitRootDependencies(packageName, dependencies) {
           .join('\n'),
       );
     }
-  });
+  }
 
   return filteredDependencies;
 }

biome.json

@@ -21,31 +21,29 @@
     "enabled": true,
     "rules": {
       "recommended": true,
+      "a11y": {
+        "useButtonType": "off"
+      },
+      "complexity": {
+        "noBannedTypes": "off",
+        "useLiteralKeys": "off"
+      },
       "correctness": {
         "noUnusedVariables": "error"
       },
-      "nursery": {
-        "useGroupedTypeImport": "off"
-      },
       "performance": {
         "noDelete": "off"
       },
       "style": {
         "noNonNullAssertion": "off",
-        "useShorthandArrayType": "error",
-        "useSingleVarDeclarator": "off"
+        "useShorthandArrayType": "error"
       },
       "suspicious": {
         "noArrayIndexKey": "off",
+        "noAssignInExpressions": "off",
+        "noConfusingVoidType": "off",
         "noExplicitAny": "off",
         "noRedeclare": "off"
-      },
-      "complexity": {
-        "useLiteralKeys": "off",
-        "noForEach": "off"
-      },
-      "a11y": {
-        "noSvgWithoutTitle": "off"
       }
     }
   },

package.json

@@ -41,7 +41,7 @@
   },
   "license": "MIT",
   "devDependencies": {
-    "@biomejs/biome": "1.3.3",
+    "@biomejs/biome": "1.4.1",
     "@changesets/cli": "2.26.2",
     "@commitlint/cli": "^18.4.2",
     "@commitlint/config-conventional": "^18.4.2",

packages/create-rainbowkit/src/cli.ts

@@ -173,10 +173,10 @@ async function run() {
     const packageManager = options.usePnpm
       ? 'pnpm'
       : options.useYarn
-      ? 'yarn'
-      : options.useNpm
-      ? 'npm'
-      : detectPackageManager();
+        ? 'yarn'
+        : options.useNpm
+          ? 'npm'
+          : detectPackageManager();
 
     log(
       chalk.cyan(

packages/create-rainbowkit/src/detectPackageManager.ts

@@ -7,13 +7,9 @@ export function detectPackageManager(): PackageManager {
     const userAgent = process.env.npm_config_user_agent;
 
     if (userAgent) {
-      if (userAgent.startsWith('pnpm')) {
-        return 'pnpm';
-      } else if (userAgent.startsWith('yarn')) {
-        return 'yarn';
-      } else if (userAgent.startsWith('npm')) {
-        return 'npm';
-      }
+      if (userAgent.startsWith('pnpm')) return 'pnpm';
+      if (userAgent.startsWith('yarn')) return 'yarn';
+      if (userAgent.startsWith('npm')) return 'npm';
     }
     try {
       execSync('pnpm --version', { stdio: 'ignore' });

packages/example/pages/_app.tsx

@@ -218,10 +218,10 @@ const themes = [
   { name: 'dark', theme: darkTheme },
   { name: 'midnight', theme: midnightTheme },
 ] as const;
-type ThemeName = typeof themes[number]['name'];
+type ThemeName = (typeof themes)[number]['name'];
 
 const fontStacks = ['rounded', 'system'] as const;
-type FontStack = typeof fontStacks[number];
+type FontStack = (typeof fontStacks)[number];
 
 const accentColors = [
   'blue',
@@ -232,16 +232,16 @@ const accentColors = [
   'red',
   'custom',
 ] as const;
-type AccentColor = typeof accentColors[number];
+type AccentColor = (typeof accentColors)[number];
 
 const radiusScales = ['large', 'medium', 'small', 'none'] as const;
-type RadiusScale = typeof radiusScales[number];
+type RadiusScale = (typeof radiusScales)[number];
 
 const overlayBlurs = ['large', 'small', 'none'] as const;
-type OverlayBlur = typeof overlayBlurs[number];
+type OverlayBlur = (typeof overlayBlurs)[number];
 
 const modalSizes = ['wide', 'compact'] as const;
-type ModalSize = typeof modalSizes[number];
+type ModalSize = (typeof modalSizes)[number];
 
 function RainbowKitApp({
   Component,

packages/example/pages/api/auth/[...nextauth].ts

@@ -15,7 +15,7 @@ export function getAuthOptions(req: IncomingMessage): NextAuthOptions {
       async authorize(credentials) {
         try {
           const siwe = new SiweMessage(
-            JSON.parse(credentials?.message || '{}')
+            JSON.parse(credentials?.message || '{}'),
           );
 
           const nextAuthUrl =
@@ -95,7 +95,7 @@ export default async function auth(req: NextApiRequest, res: NextApiResponse) {
 
   const isDefaultSigninPage =
     req.method === 'GET' &&
-    req.query.nextauth.find(value => value === 'signin');
+    req.query.nextauth.find((value) => value === 'signin');
 
   // Hide Sign-In with Ethereum from default sign page
   if (isDefaultSigninPage) {

packages/rainbowkit/src/components/AsyncImage/useAsyncImage.ts

@@ -5,7 +5,6 @@ export type AsyncImageSrc = () => Promise<string>;
 const cachedUrls = new Map<AsyncImageSrc, string>();
 
 // Store requests in a cache so we don't fetch the same image twice
-// biome-ignore lint/suspicious/noConfusingVoidType: TODO
 const cachedRequestPromises = new Map<AsyncImageSrc, Promise<string | void>>();
 
 async function loadAsyncImage(asyncImage: () => Promise<string>) {

packages/rainbowkit/src/components/Button/ActionButton.tsx

@@ -61,8 +61,8 @@ export function ActionButton({
     ? isPrimary
       ? 'accentColor'
       : isNotLarge
-      ? 'actionButtonSecondaryBackground'
-      : null
+        ? 'actionButtonSecondaryBackground'
+        : null
     : 'actionButtonSecondaryBackground';
   const { fontSize, height, paddingX, paddingY } = sizeVariants[size];
   const hasBorder = !mobile || !isNotLarge;

packages/rainbowkit/src/components/ChainModal/ChainModal.test.tsx

@@ -63,7 +63,6 @@ describe('<ChainModal />', () => {
   it('Can switch chains', async () => {
     let onCloseGotCalled = false;
     const modal = renderWithProviders(
-      // biome-ignore lint/suspicious/noAssignInExpressions: TODO
       <ChainModal onClose={() => (onCloseGotCalled = true)} open />,
       {
         mock: true,
@@ -90,7 +89,6 @@ describe('<ChainModal />', () => {
   it('Just closes on switch error (user rejected, or other)', async () => {
     let onCloseGotCalled = false;
     const modal = renderWithProviders(
-      // biome-ignore lint/suspicious/noAssignInExpressions: TODO
       <ChainModal onClose={() => (onCloseGotCalled = true)} open />,
       {
         mock: true,
@@ -134,7 +132,6 @@ describe('<ChainModal />', () => {
   it('Closes on close button press', async () => {
     let onCloseGotCalled = false;
     const modal = renderWithProviders(
-      // biome-ignore lint/suspicious/noAssignInExpressions: TODO
       <ChainModal onClose={() => (onCloseGotCalled = true)} open />,
       {
         mock: true,