Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NFT save #6356

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from
Draft

Fix NFT save #6356

wants to merge 4 commits into from

Conversation

brunobar79
Copy link
Member

@brunobar79 brunobar79 commented Dec 19, 2024 •
edited
Loading

Fixes APP-1782

What changed (plus any additional context for devs)

  • The library we were using doesn't support downloading remote nfts so we had to download it first and then we're being able to save it to the camera roll
  • The profile links we were building were no longer working. Fixed those and now "view on rainbow.me" and sharing too.
    however the website has some issues on mobile were the popup that shows the specific NFT doesn't work but that's out of scope.
  • Converted to typescript

Screen recordings / screenshots

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-12-18.at.19.23.56.mp4

What to test

  • Grab any NFT and save it.
  • Try to share it or view on rainbow.me - then verify that link works fine on desktop (mobile won't work bc of the website)

@ibrahimtaveras00 can u give it a try on android?

@linear Linear
Copy link

linear bot commented Dec 19, 2024

APP-1782 Updated Issue: Failed to Save Image

@brunobar79
Copy link
Member Author

Launch in simulator or device for 244f4a8

@brunobar79 brunobar79 requested a review from walmat December 31, 2024 18:42
@brunobar79
Copy link
Member Author

Launch in simulator or device for c5e9cba

@brunobar79
Copy link
Member Author

Launch in simulator or device for 6aee56b

ibrahimtaveras00
ibrahimtaveras00 requested changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works fine on iOS, however, when I attempt to test on Android device, I see a notification from the download manager that the download was unsuccessful

seen here:

Screen.Recording.2025-01-02.at.11.55.15.AM.mov
Screenshot 2025-01-02 at 12 07 35 PM

walmat
walmat reviewed Jan 3, 2025
View reviewed changes
src/components/expanded-state/unique-token/UniqueTokenExpandedStateHeader.tsx
Comment on lines +360 to +363
if (asset?.image_url) {
const fullResUrl = getFullResUrl(asset.image_url);
fullResUrl && saveToCameraRoll(fullResUrl);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we even show the save button if there's nothing to save?

walmat
walmat requested changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@walmat walmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same issue as Ibrahim described. iOS works well though

@brunobar79 brunobar79 marked this pull request as draft January 3, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 requested changes

@walmat walmat walmat requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brunobar79 @walmat @ibrahimtaveras00