3008 cleanup and enabling test #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* - Added start for cypress test suite * - Added cypress tests to the task file * - initial config for circi * - converting from task to bash command for the moment * - fix format * - changing executor * - install node packages * - new node command * - fixed syntax * - debugging * - use npm to install packages * - install task with NOde * - remove unneeded orb * - Adding git hooks * - update format * - add missing quote * - naming * - Fix naming * - Updating paths * - Removing unnecessary param * - docs update * - remove settings file - add .vscode to igniore * - Fix merge conflicts * - Updated model to use correct multiselect filter - adding stub cypress test for using custom filter * - Update so dummy models and admin classes work - Updated multiselect filter to work * - Added test for multiselect filtering * - missing newline * - changing url to avoid redirect * - update test task * - revert * - add init task
7 tasks
Closed
8 tasks
elipe17
reviewed
Jun 24, 2024
elipe17
reviewed
Jun 24, 2024
elipe17
reviewed
Jun 24, 2024
| database_config = { | ||
| "sqlite": { | ||
| "ENGINE": "django.db.backends.sqlite3", | ||
| "NAME": ":memory:", |
There was a problem hiding this comment.
Since the sqlite DB is always in memory, does that mean we have to run makemigrations and other init commands for each call to task up? Or does the in memory DB still get serialized to disk when the container is brought down?
There was a problem hiding this comment.
sqlite is in fact not in memory but on disk. it creates .sqlite file
There was a problem hiding this comment.
If that is the case can we specify an actual name for the DB? :memory: is supposed to be a special name in sqlite and I'd be worried about unintended side effects! See here.
elipe17
approved these changes
Jun 26, 2024
jtimpe
reviewed
Jun 27, 2024
| - checkout | ||
| - install_node_packages | ||
| - run: task init | ||
| - run: task test |
There was a problem hiding this comment.
it might be nice to split the different test runs in circleci so they show as different steps
jtimpe
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
Various cleanups, deletion, additions:
How to test:
Run task pytest, this will run the pytest files. Additionally, you cypress end-to-end test can run using task command.
How tested:
In addition to added pytests to ensure the package is still compliant with TANF-app, the package was pulled as a dependency into TANF app and admin page was browsed, and tested using cypress test. The filters seemed to work as expected.