Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing ignored games skips every other page #1791

Open
Lunatrius opened this issue Dec 23, 2023 · 0 comments
Open

Removing ignored games skips every other page #1791

Lunatrius opened this issue Dec 23, 2023 · 0 comments

Comments

@Lunatrius
Copy link

Lunatrius commented Dec 23, 2023

Description
When removing ignored games from the account filters all even pages are skipped, because page 1 will cleared instantly, then the script will load the second page. However at that time page 2 would have been the old page 3, prior to removing everything on page 1.

The same thing happens with page 3, pages 1 and 3 have been cleared, leaving 2, 4, 5, 6, ... in the queue and the original page 5 is now the 3rd page.

Steps to Reproduce

  1. Go to "https://www.steamgifts.com/account/settings/giveaways/filters"
  2. Click on the add/remove games button next to "Sort by: Game"
  3. Leave everything on default (text area empty, all settings off)
  4. Click "Remove"
  5. Once done, every even page won't have been deleted

Expected Behavior
Entries should be deleted from all pages.

Should be easily fixable by either going in the reverse direction or always removing the first page (since pages work similar to a queue in this specific case).

Console Errors
None.

Screenshots
2023-12-23_19-56-29

System (please complete the following information):

  • ESGST Version: Extension v8.9.4
  • Browser + Version: Firefox 121.0

Additional Context
None.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant