Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stricter types for grayColor / resolvedGrayColor #639

Open
ijxy opened this issue Dec 13, 2024 · 0 comments
Open

Stricter types for grayColor / resolvedGrayColor #639

ijxy opened this issue Dec 13, 2024 · 0 comments

Comments

@ijxy
Copy link

ijxy commented Dec 13, 2024

The resolvedGrayColor is currently typed using the GrayColor type, which includes "auto" (which is not a resolved value).

I'd like to propose changing the types so that the resolvedGrayColor type excludes "auto".

Implementation ideas:

  1. change the type of GrayColor to exclude "auto" and change the theme input type for grayColor to GrayColor | "auto" (which could be explicitly named something like ResolvableGrayColor if desirable)
  2. add a new ResolvedGrayColor = Exclude<GrayColor | "auto"> type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant