-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of Dapr Building Block: Bindings #7970
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7970 +/- ##
==========================================
+ Coverage 60.62% 60.66% +0.03%
==========================================
Files 534 538 +4
Lines 28488 28689 +201
==========================================
+ Hits 17271 17403 +132
- Misses 9701 9760 +59
- Partials 1516 1526 +10 ☔ View full report in Codecov by Sentry. |
@SoTrx, Thank you again for the amazing contributions! |
Sure ! |
4e6e34b
to
8496b05
Compare
Signed-off-by: SoTrx <[email protected]>
This reverts commit 8496b05. Signed-off-by: SoTrx <[email protected]>
Signed-off-by: SoTrx <[email protected]>
Signed-off-by: SoTrx <[email protected]>
a7fea59
to
6757856
Compare
Signed-off-by: SoTrx <[email protected]>
I've removed the scopes implementations from this one and made the proposed schema changes for the Bindings Building Block. I just saw the new PR checklist—should I also create a PR in the design notes repo? |
Thank you for the update and for providing detailed information in the issue: #7960. ccing @rynowak, @kachawla, and @willtsai for input as well. |
If you have time, that would be awesome. We like to see a design document for API changes. Adding a new resource type is definitely design-doc worthy. There are lots of examples, feel free to ping any of us on discord if you want pointers or feedback. |
Description
Hey,
This PR introduces support for Dapr Bindings
Type of change
Fixes: #7960