Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Commit Status Display for radius repo needs improvement #7884

Open
1 task
lakshmimsft opened this issue Sep 4, 2024 · 2 comments
Open
1 task

Code Commit Status Display for radius repo needs improvement #7884

lakshmimsft opened this issue Sep 4, 2024 · 2 comments
Labels
maintenance Issue is a non-user-facing task like updating tests, improving automation, etc.. triaged This issue has been reviewed and triaged

Comments

@lakshmimsft
Copy link
Contributor

lakshmimsft commented Sep 4, 2024

Area for Improvement

The status of code commits in radius repo can be misleading. It displays a failed status for 'Functional Test Run' for multiple commits which, upon clicking Details, seems to be a history of test runs on the commit including the Long Running Tests, (which run only on schedule off the main branch). We need to update it so it shows correct status of a commit.

Observed behavior

  1. On the radius repo Code page on Github, click on Commits:
image ______________________________________________________________________________
  1. We see a list of commits , a lot of them have a red x next to it. eg:
image
  1. If we click on the x, it brings up a display of statuses including a failed Functional Test Run which can give incorrect information to the user that that this commit was merged into main and it did not pass tests.
image ______________________________________________________________________________ 5. Upon clicking 'Details' we go to https://github.com/radius-project/radius/runs/29530700484 This seems to be a history of all tests the commit has gone through including Long Running Tests which may have had failures in the past.

Desired behavior

The Functional Test Run name in the list is misleading in the current display and does not match the data it is showing. It needs to be renamed appropriately.
Investigate how this is included in the list of display statuses for each commit and determine if needs to be included.
This may be associated with the GitHub app Functional Test Run created to report results of tests.

Proposed Fix

N/A

rad Version

N/A

Operating system

N/A

Additional context

Additional rights may be needed on the github repo to access github apps and investigate further.

Would you like to support us?

  • Yes, I would like to support you

AB#13147

@lakshmimsft lakshmimsft added the maintenance Issue is a non-user-facing task like updating tests, improving automation, etc.. label Sep 4, 2024
@radius-triage-bot
Copy link

👋 @lakshmimsft Thanks for filing this issue.

A project maintainer will review this issue and get back to you soon.

We also welcome community contributions! If you would like to pick this item up sooner and submit a pull request, please visit our contribution guidelines and assign this to yourself by commenting "/assign" on this issue.

For more information on our triage process please visit our triage overview

@lakshmimsft lakshmimsft added the triaged This issue has been reviewed and triaged label Sep 5, 2024
@radius-triage-bot
Copy link

👍 We've reviewed this issue and have agreed to add it to our backlog. Please subscribe to this issue for notifications, we'll provide updates when we pick it up.

We also welcome community contributions! If you would like to pick this item up sooner and submit a pull request, please visit our contribution guidelines and assign this to yourself by commenting "/assign" on this issue.

For more information on our triage process please visit our triage overview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Issue is a non-user-facing task like updating tests, improving automation, etc.. triaged This issue has been reviewed and triaged
Projects
None yet
Development

No branches or pull requests

1 participant