Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate custom actions for publishing Bicep types #7828

Open
1 task
sk593 opened this issue Aug 21, 2024 · 4 comments
Open
1 task

Investigate custom actions for publishing Bicep types #7828

sk593 opened this issue Aug 21, 2024 · 4 comments
Labels
maintenance Issue is a non-user-facing task like updating tests, improving automation, etc.. needs-more-information This issue needs more information. triaged This issue has been reviewed and triaged

Comments

@sk593
Copy link
Contributor

sk593 commented Aug 21, 2024

Area for Improvement

There are multiple workflows where we need to publish Bicep types to ACR. Some steps when we do this overlap between workflows. We should investigate if these can be moved to a custom action and reused across workflows.

Observed behavior

An example workflow for publish Bicep can be found here:

name: Publish Radius bicep types to ACR

Desired behavior

We should have a custom action for the publish Bicep steps and reuse that action in our workflows.

Proposed Fix

We should add a custom actions workflow for publishing Bicep types. This would handle the setup steps like generating types, uploading artifacts, and publishing to ACR. This way, if we need to update the publish steps, we only need to update as single actions workflow as opposed to multiple areas.

rad Version

GH version of radius

Operating system

No response

Additional context

No response

Would you like to support us?

  • Yes, I would like to support you

AB#13049

@sk593 sk593 added the maintenance Issue is a non-user-facing task like updating tests, improving automation, etc.. label Aug 21, 2024
@radius-triage-bot
Copy link

👋 @sk593 Thanks for filing this issue.

A project maintainer will review this issue and get back to you soon.

We also welcome community contributions! If you would like to pick this item up sooner and submit a pull request, please visit our contribution guidelines and assign this to yourself by commenting "/assign" on this issue.

For more information on our triage process please visit our triage overview

@ytimocin ytimocin added the triaged This issue has been reviewed and triaged label Aug 26, 2024
@radius-triage-bot
Copy link

👍 We've reviewed this issue and have agreed to add it to our backlog. Please subscribe to this issue for notifications, we'll provide updates when we pick it up.

We also welcome community contributions! If you would like to pick this item up sooner and submit a pull request, please visit our contribution guidelines and assign this to yourself by commenting "/assign" on this issue.

For more information on our triage process please visit our triage overview

@ytimocin ytimocin added the needs-more-information This issue needs more information. label Aug 26, 2024
@radius-triage-bot
Copy link

👋 @sk593 we need more information.

To help us investigate further, we need additional information to reproduce or understand this issue. Please ensure you have steps to reproduce and information about your OS, rad CLI version, and runtime version.

A project maintainer will reply on this issue soon to ask for additional specifics if needed.

For more information on our triage process please visit our triage overview

@ytimocin
Copy link
Contributor

Can you add more information on what we are improving here @sk593? Like what are the measurable downsides of the current design vs what we want to have with this issue? For example, we would need to update in a few different places instead of one and that would require more time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Issue is a non-user-facing task like updating tests, improving automation, etc.. needs-more-information This issue needs more information. triaged This issue has been reviewed and triaged
Projects
None yet
Development

No branches or pull requests

2 participants