Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download button do not allow popup new download in separate tab #583

Open
luipir opened this issue Mar 12, 2025 · 2 comments
Open

Download button do not allow popup new download in separate tab #583

luipir opened this issue Mar 12, 2025 · 2 comments
Labels

Comments

@luipir
Copy link

luipir commented Mar 12, 2025

We had an issue integrating stac-browser in the PCKE infrastructure that we have to use. Due to issue/limitation, we want to override it opening download in a separate popup but the stac-broser do not do this in a https context.
The reason of this is that stac-browser is using StreamSaver.js here to allow stream download.

IMHO this behaviour should be configurable and do not force to remain in the same page opening an hidden iframe.

The issue is reproducible in HTTPS download where the StreamSaver.js create an hidden iframe to manage the stream. if context is not secure (e.g. http download), then a new tab is open to create secure connection.

I already open a feature request to StreamStream.js to add a configuration parameter to force or not iframe/popup use:
jimmywarting/StreamSaver.js#359

@luipir
Copy link
Author

luipir commented Mar 13, 2025

I was copletly wrong and no altDownload was used. instead the new popup was prevented by download property set to download="download" in:
https://github.com/radiantearth/stac-browser/blob/main/src/components/HrefActions.vue#L162

I'll prepare a PR to allow this disable by conf if I understand how configuration is propagated and accessed in each component.

@m-mohr
Copy link
Collaborator

m-mohr commented Mar 18, 2025

I don't understand what the actual issue is here. Why would you want a popup?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants