Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to disable "Share on Twitter" feature #510

Open
vprivat-ads opened this issue Nov 27, 2024 · 4 comments
Open

Possibility to disable "Share on Twitter" feature #510

vprivat-ads opened this issue Nov 27, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@vprivat-ads
Copy link

Twitter is no longer the friendly public agora we knew a few years ago, and I couldn't find an option to disable this integration. Is it possible add a new option to disable this?

image

@m-mohr
Copy link
Collaborator

m-mohr commented Nov 27, 2024

Not right now unless you change it in the code directly. PRs welcome.

@m-mohr m-mohr added the enhancement New feature or request label Nov 27, 2024
@vprivat-ads
Copy link
Author

ok :) no objection to add other share links (twitter, bluesky, linkedin, etc.), and let the user configure which ones are enabled?

@m-mohr
Copy link
Collaborator

m-mohr commented Nov 27, 2024

No objection, actually there are libraries for Vue that do that (e.g. https://www.npmjs.com/package/vue-social-sharing and https://github.com/koddr/vue-goodshare - just a quick search, no preference), which we should probably use. The ones we have right now just are there because they just work out of the box with simple links and without dependencies and additional code. I don't want to maintain those API specifics in STAC Browser, but if it's maintained externally, it's fine to add more.

PS: 3.3.0 is pretty much in a feature-freeze until the release. So it may take a bit until PRs will be released in a later version.
PPS: A new dependency would need to have both Vue 2 and Vue 3 compatibility as we are planning to migrate to Vue 3 next year or a little later.

@vprivat-ads
Copy link
Author

Ok, thank you for the insight, I'll take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants