-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The Show on map
button is not being shown for s3 links COG files
#372
Comments
STAC Browser can't read from S3:// urls. What you are probably seeing is the thumbnail. I assume there's a bug in labelling the right asset with the "shown" badge. I'll wait with a fix for the OpenLayers migration unless someone has funding to fix this specifically. |
Thanks for getting back to me. Correct me if I'm wrong, but I can see that the And it's showing the result. So it isn't intentional? |
If it does, it's not intentional. Also, your link errors for me. |
Oh, I see. The quality mask asset is being shown. Could you please confirm that? If not, I need to look for another way to reproduce this for you. Thanks. |
I see the issue via the url. It indeed shows the quality mask through the pre-defined tile server. The issue is STAC Browser can't know upfront whether a tile server is used and what the capabilities of the tile server are. I wasn't aware until today that the pre-defined one supports s3. And if you configure another one, I don't know what that server supports. I'm not sure how to fix this (apart from not selecting a s3 image to be shown by default, but that is the opposite of what you want.) [that's a bug and will be "fixed" in 3.2.0] Maybe we need some kind of "can be shown on map" function in the config for the tile servers? Than everyone can implement that on their own. This may need also some code-changes in ol-stac and stac-layer. [that's an enhancement and needs funding] |
I might be wrong here. (I haven't been keeping up with all the updates as I should). But doesn't tile-layer check if the tile server supports S3 by basically just checking if it can load the image? |
Context:
Let's say I have an STAC item with the fllowing
assets
object:Current behavior:
When I open the
ITEM
page, I can see theFIRST_COG_FILE
and theSHOWN
badge (Green one), but I cannot see theShow on map
button for theSECOND_COG_FILE
asset.Let me know if you need more information/clarification.
Expected behavior:
I should be able to change the
SHOWN
asset even if they're using the s3 protocol.I'll be happy to work on this (I've already done something) if you're also agreed on the expected behavior.
Thanks.
The text was updated successfully, but these errors were encountered: