Skip to content
This repository has been archived by the owner on Feb 16, 2022. It is now read-only.

Globally unique model_id field #8

Open
duckontheweb opened this issue Apr 5, 2021 · 1 comment
Open

Globally unique model_id field #8

duckontheweb opened this issue Apr 5, 2021 · 1 comment
Assignees
Labels
change Involves change to existing spec discussion needed Requires further discussion/input before implementing
Milestone

Comments

@duckontheweb
Copy link
Collaborator

Problem Description

The spec currently requires that the model_id be unique "across the provider", but there is not guarantee that it be globally unique. This could lead to confusion if different models have identical IDs in a few different model repositories, or if the same model has different IDs in different repos in order to avoid a conflict with another model. Requiring a UUID as the model_id would effectively guarantee global uniqueness and would mean that the same ID could be reliably reused across multiple providers to reference the same model.

This issue exists to encourage discussion regarding the pros and cons of requiring a globally unique model_id. If there is consensus that this change should be made we will update the Proposal section with a proposed implementation.

Proposal

TBD

@duckontheweb duckontheweb added discussion needed Requires further discussion/input before implementing change Involves change to existing spec labels Apr 5, 2021
@duckontheweb duckontheweb self-assigned this Apr 5, 2021
@duckontheweb duckontheweb added this to the v0.1.0 milestone Apr 7, 2021
@duckontheweb duckontheweb modified the milestones: v0.1.0, v0.2.0 May 13, 2021
@m-mohr
Copy link

m-mohr commented Sep 1, 2021

Could the URI be the globally unique identifier instead?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
change Involves change to existing spec discussion needed Requires further discussion/input before implementing
Projects
None yet
Development

No branches or pull requests

2 participants