WIP: Start refactoring of esil engine #23663
Merged
+663
−187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trufae
reviewed
Nov 22, 2024
|
|
||
| typedef struct r_esil_memory_interface_t { | ||
| void *mem; | ||
| REsilMemSwitch mem_switch; |
There was a problem hiding this comment.
yes, but it's optional, so you could also use something that doesn't provide banking
trufae
reviewed
Nov 22, 2024
libr/include/r_esil.h
Outdated
| typedef bool (*REsilMemWrite)(void *mem, ut64 addr, const ut8 *buf, int len); | ||
|
|
||
| typedef struct r_esil_memory_interface_t { | ||
| void *mem; |
There was a problem hiding this comment.
yes, within r2 this would be RIO *
There was a problem hiding this comment.
Better user userdata instead of mem for cosistency
condret
force-pushed
the
esil_diet
branch
2 times, most recently
from
a531574
to
fab7770
Compare
|
build fails because you cant use io apis from esil library, because it hasnt been built yet. you can use RIOBind instead or try to mess with the library dependency order in library/libs.mk |
condret
force-pushed
the
esil_diet
branch
10 times, most recently
from
089700a
to
948c131
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description