gazelle: compact rules use wildcard (#166)

* Use globs when generating "compact" rules with gazelle

* when using compact rules, erlang_bytecode rules refer to :hdrs

instead of individual files

* Make globs in generated app.bzl files multiline when long

* Use native.glob inside of macros in generated app.bzl files

* Remove the extension restriction for hdrs attributes

Otherwise globs that turn out to be empty can't be passed to the rule

Author: HoloRin

erlang_app.bzl

@@ -54,14 +54,20 @@ def _erlang_app(
         beam_files = None,
         hdrs = None,
         srcs = None,
+        priv = None,
+        license_files = None,
         test = False):
-    if beam_files != None or hdrs != None or srcs != None:
+    if beam_files != None or hdrs != None or srcs != None or priv != None or license_files != None:
         if erlc_opts != None:
-            fail("Cannot set beam_files, hdrs or srcs AND erlc_opts")
+            fail("Cannot set beam_files, hdrs, srcs, priv or license_files AND erlc_opts")
         if len(extra_hdrs) > 0:
-            fail("Cannot set beam_files, hdrs or srcs AND extra_hdrs")
+            fail("Cannot set beam_files, hdrs, srcs, priv or license_files AND extra_hdrs")
         if len(extra_srcs) > 0:
-            fail("Cannot set beam_files, hdrs or srcs AND extra_srcs")
+            fail("Cannot set beam_files, hdrs, srcs, priv or license_files AND extra_srcs")
+        if len(extra_priv) > 0:
+            fail("Cannot set beam_files, hdrs, srcs, priv or license_files AND extra_priv")
+        if len(extra_license_files) > 0:
+            fail("Cannot set beam_files, hdrs, srcs, priv or license_files AND extra_license_files")
         if len(build_deps) > 0:
             print("Warning: build_deps are ignored when beam_files is set")
         if len(runtime_deps) > 0:
@@ -138,18 +144,27 @@ def _erlang_app(
     else:
         app = "ebin/{}.app".format(app_name)
 
+    if priv == None:
+        priv = native.glob(
+            ["priv/**/*"],
+            exclude = extra_priv,
+        ) + extra_priv
+
+    if license_files == None:
+        license_files = native.glob(
+            ["LICENSE*"],
+            exclude = extra_license_files,
+        ) + extra_license_files
+
     erlang_app_info(
         name = name,
         app_name = app_name,
         extra_apps = extra_apps,
         hdrs = hdrs,
         app = app,
         beam = beam_files,
-        priv = native.glob(["priv/**/*"]) + extra_priv,
-        license_files = native.glob(
-            ["LICENSE*"],
-            exclude = extra_license_files,
-        ) + extra_license_files,
+        priv = priv,
+        license_files = license_files,
         srcs = srcs,
         deps = deps + runtime_deps,
         visibility = ["//visibility:public"],

erlang_app_info.bzl

@@ -60,7 +60,7 @@ erlang_app_info = rule(
     attrs = {
         "app_name": attr.string(mandatory = True),
         "extra_apps": attr.string_list(),
-        "hdrs": attr.label_list(allow_files = [".hrl"]),
+        "hdrs": attr.label_list(allow_files = True),
         "app": attr.label(allow_files = [".app"]),
         "beam": attr.label_list(allow_files = [".beam", ".appup"]),
         "priv": attr.label_list(allow_files = True),

erlang_bytecode2.bzl

@@ -7,8 +7,32 @@ load(
 
 ErlcOptsInfo = _ErlcOptsInfo
 
-def erlang_bytecode(**kwargs):
-    _erlang_bytecode(**kwargs)
+def erlang_bytecode(
+        srcs = [],
+        outs = None,
+        dest = None,
+        **kwargs):
+    if len(srcs) == 0:
+        fail("srcs cannot be empty")
+    if outs != None and dest != None:
+        fail('"outs" and "dest" cannot be set together')
+    if outs == None:
+        if dest == None:
+            fail('either "outs" or "dest" must be set')
+        outs = [
+            dest + "/" + _beam(src)
+            for src in srcs
+        ]
+
+    _erlang_bytecode(
+        srcs = srcs,
+        outs = outs,
+        **kwargs
+    )
 
 def erlc_opts(**kwargs):
     _erlc_opts(**kwargs)
+
+def _beam(p):
+    (_, _, basename) = p.rpartition("/")
+    return basename.removesuffix(".erl") + ".beam"

gazelle/BUILD.bazel

@@ -15,6 +15,7 @@ go_library(
         "erl_parser.go",
         "erl_parser_impl.go",
         "erlang_app.go",
+        "erlang_app_builder.go",
         "fix.go",
         "generate.go",
         "hex_metadata_parser.go",