Merge pull request #255 from rabbitmq/absurd-mode

Eliminate the need for gazelle language extension

Author: HoloRin

.github/workflows/test.yaml

@@ -289,42 +289,6 @@ jobs:
         if [[ "${{ steps.before.outputs.otp }}" == "${{ steps.after.outputs.otp }}" ]]; then
           echo "Fail"
         fi
-  test-gazelle-extension:
-    runs-on: ubuntu-20.04
-    steps:
-    - name: CHECKOUT
-      uses: actions/checkout@v4
-    - name: CONFIGURE ERLANG
-      uses: erlef/setup-beam@v1
-      with:
-        otp-version: 26
-    - name: CONFIGURE BAZEL
-      working-directory: test
-      run: |
-        cat << EOF >> user.bazelrc
-          build --color=yes
-        EOF
-    - name: TEST GAZELLE PACKAGE (UNIT_SUITE)
-      working-directory: test
-      run: |
-        bazelisk test //gazelle:unit_suite
-    - name: TEST GAZELLE PACKAGE (INTEGRATION_SUITE)
-      working-directory: test
-      run: |
-        bazelisk test //gazelle:integration_suite --test_env PATH \
-          || bazelisk test //gazelle:integration_suite --test_env PATH
-    - name: RESOVLE TEST LOGS PATH
-      if: always()
-      working-directory: test
-      run: |
-        echo "LOGS_PATH=$(readlink -f bazel-testlogs)" >> $GITHUB_OUTPUT
-      id: resolve-test-logs-path
-    - name: CAPTURE TEST LOGS
-      if: always()
-      uses: actions/upload-artifact@v4
-      with:
-        name: bazel-testlogs-gazelle
-        path: ${{ steps.resolve-test-logs-path.outputs.LOGS_PATH }}/*
   summary:
     needs:
     - unit-test
@@ -336,7 +300,6 @@ jobs:
     - test-bzlmod-internal-erlang
     - test-bzlmod-coverage
     - test-host-erlang-change-detected
-    - test-gazelle-extension
     runs-on: ubuntu-latest
     steps:
     - name: SUMMARY

BUILD.bazel

@@ -1,5 +1,4 @@
 load("@bazel_skylib//rules:common_settings.bzl", "string_flag")
-load("@bazel_gazelle//:def.bzl", "gazelle")
 load(":util_test.bzl", "util_test_suite")
 
 config_setting(
@@ -33,22 +32,4 @@ string_flag(
     visibility = ["//visibility:public"],
 )
 
-# Gazelle configuration options.
-# See https://github.com/bazelbuild/bazel-gazelle#running-gazelle-with-bazel
-# gazelle:prefix github.com/rabbitmq/rules_erlang
-# gazelle:exclude bazel-out
-gazelle(name = "gazelle")
-
-gazelle(
-    name = "update_go_deps",
-    args = [
-        "-from_file=go.mod",
-        "-to_macro=gazelle/deps.bzl%gazelle_deps",
-        "-prune",
-    ],
-    command = "update-repos",
-)
-
-# Tests
-
 util_test_suite(name = "util_tests")

BUILD.thoas

@@ -1,94 +1,8 @@
-load("@rules_erlang//:erlang_bytecode2.bzl", "erlang_bytecode", "erlc_opts")
 load("@rules_erlang//:erlang_app.bzl", "erlang_app")
 
-erlc_opts(
-    name = "erlc_opts",
-    values = select({
-        "@rules_erlang//:debug_build": [
-            "+debug_info",
-        ],
-        "//conditions:default": [
-            "+debug_info",
-            "+deterministic",
-        ],
-    }),
-    visibility = [":__subpackages__"],
-)
-
-erlang_bytecode(
-    name = "other_beam",
-    srcs = [
-        "src/thoas.erl",
-        "src/thoas_decode.erl",
-        "src/thoas_encode.erl",
-    ],
-    outs = [
-        "ebin/thoas.beam",
-        "ebin/thoas_decode.beam",
-        "ebin/thoas_encode.beam",
-    ],
-    hdrs = [],
-    app_name = "thoas",
-    beam = [],
-    erlc_opts = "//:erlc_opts",
-)
-
-filegroup(
-    name = "beam_files",
-    srcs = [":other_beam"],
-)
-
-filegroup(
-    name = "srcs",
-    srcs = [
-        "src/thoas.app.src",
-        "src/thoas.erl",
-        "src/thoas_decode.erl",
-        "src/thoas_encode.erl",
-    ],
-)
-
-filegroup(
-    name = "private_hdrs",
-    srcs = [],
-)
-
-filegroup(
-    name = "public_hdrs",
-    srcs = [],
-)
-
-filegroup(
-    name = "priv",
-    srcs = [],
-)
-
-filegroup(
-    name = "licenses",
-    srcs = ["LICENSE"],
-)
-
-filegroup(
-    name = "public_and_private_hdrs",
-    srcs = [
-        ":private_hdrs",
-        ":public_hdrs",
-    ],
-)
-
-filegroup(
-    name = "all_srcs",
-    srcs = [
-        ":public_and_private_hdrs",
-        ":srcs",
-    ],
-)
-
 erlang_app(
     name = "erlang_app",
-    srcs = [":all_srcs"],
     app_name = "thoas",
-    beam_files = [":beam_files"],
 )
 
 alias(

MODULE.bazel

@@ -1,49 +1,30 @@
 module(
     name = "rules_erlang",
-    version = "3.15.2",
-    compatibility_level = 3,
+    version = "4.0.0",
+    compatibility_level = 4,
 )
 
-bazel_dep(
-    name = "rules_go",
-    version = "0.41.0",
-    repo_name = "io_bazel_rules_go",
-)
 bazel_dep(
     name = "bazel_skylib",
     version = "1.4.2",
 )
-bazel_dep(
-    name = "gazelle",
-    version = "0.33.0",
-    repo_name = "bazel_gazelle",
-)
-
-go_deps = use_extension("@bazel_gazelle//:extensions.bzl", "go_deps")
-go_deps.from_file(go_mod = "@rules_erlang//:go.mod")
-use_repo(
-    go_deps,
-    "com_github_bazelbuild_buildtools",
-    "com_github_bmatcuk_doublestar_v4",
-    "in_gopkg_yaml_v2",
-)
 
 erlang_package = use_extension(
     "//bzlmod:extensions.bzl",
     "erlang_package",
 )
 erlang_package.hex_package(
     name = "thoas_rules_erlang",
-    pkg = "thoas",
     build_file = "@rules_erlang//:BUILD.thoas",
+    pkg = "thoas",
     sha256 = "fc763185b932ecb32a554fb735ee03c3b6b1b31366077a2427d2a97f3bd26735",
     version = "1.0.0",
 )
 use_repo(
     erlang_package,
     "getopt_src",
-    "xref_runner_src",
     "thoas_rules_erlang",
+    "xref_runner_src",
 )
 
 erlang_config_extension = use_extension(
@@ -55,7 +36,17 @@ use_repo(
     "erlang_config",
 )
 
+gmake_config_extension = use_extension(
+    "@rules_erlang//bzlmod:extensions.bzl",
+    "gmake_config",
+)
+use_repo(
+    gmake_config_extension,
+    "gmake_config",
+)
+
 register_toolchains(
     "@erlang_config//external:toolchain_major",
     "@erlang_config//external:toolchain_major_minor",
+    "@gmake_config//:default_toolchain",
 )