Skip to content

Commit 63d9994

Browse files
authored
Merge pull request #85 from rabbitmq/source_tree-includes-private-hrl
Include src/*.hrl files in the source_tree rule's output
2 parents 89627c7 + 28b87b7 commit 63d9994

File tree

2 files changed

+38
-12
lines changed

2 files changed

+38
-12
lines changed

erlang_app.bzl

Lines changed: 37 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -51,11 +51,18 @@ def erlang_app(
5151
deps = [],
5252
runtime_deps = [],
5353
stamp = -1):
54-
srcs = native.glob(["src/**/*.erl"]) + extra_srcs
54+
srcs = native.glob(
55+
["src/**/*.erl"],
56+
exclude = extra_srcs,
57+
) + extra_srcs
58+
hdrs = native.glob(
59+
["include/**/*.hrl", "src/**/*.hrl"],
60+
exclude = extra_hdrs,
61+
) + extra_hdrs
5562

5663
erlang_bytecode(
5764
name = "beam_files",
58-
hdrs = native.glob(["include/**/*.hrl", "src/**/*.hrl"]) + extra_hdrs,
65+
hdrs = hdrs,
5966
srcs = srcs,
6067
erlc_opts = erlc_opts,
6168
dest = "ebin",
@@ -86,12 +93,21 @@ def erlang_app(
8693
erlang_app_info(
8794
name = "erlang_app",
8895
app_name = app_name,
89-
hdrs = native.glob(["include/**/*.hrl"]) + extra_hdrs,
96+
hdrs = native.glob(
97+
["include/**/*.hrl"],
98+
exclude = extra_hdrs,
99+
) + extra_hdrs,
90100
app = app,
91101
beam = [":beam_files"],
92-
priv = native.glob(["priv/**/*"]) + extra_priv,
93-
license_files = native.glob(["LICENSE*"]) + extra_license_files,
94-
srcs = srcs,
102+
priv = native.glob(
103+
["priv/**/*"],
104+
exclude = extra_priv,
105+
) + extra_priv,
106+
license_files = native.glob(
107+
["LICENSE*"],
108+
exclude = extra_license_files,
109+
) + extra_license_files,
110+
srcs = hdrs + srcs,
95111
deps = deps + runtime_deps,
96112
visibility = ["//visibility:public"],
97113
)
@@ -116,11 +132,18 @@ def test_erlang_app(
116132
build_deps = [],
117133
deps = [],
118134
runtime_deps = []):
119-
srcs = native.glob(["src/**/*.erl"]) + extra_srcs
135+
srcs = native.glob(
136+
["src/**/*.erl"],
137+
exclude = extra_srcs,
138+
) + extra_srcs
139+
hdrs = native.glob(
140+
["include/**/*.hrl", "src/**/*.hrl"],
141+
exclude = extra_hdrs,
142+
) + extra_hdrs
120143

121144
erlang_bytecode(
122145
name = "test_beam_files",
123-
hdrs = native.glob(["include/**/*.hrl", "src/**/*.hrl"]) + extra_hdrs,
146+
hdrs = hdrs,
124147
srcs = srcs,
125148
erlc_opts = erlc_opts,
126149
dest = "test",
@@ -136,12 +159,15 @@ def test_erlang_app(
136159
erlang_app_info(
137160
name = "test_erlang_app",
138161
app_name = app_name,
139-
hdrs = native.glob(["include/**/*.hrl", "src/**/*.hrl"]) + extra_hdrs,
162+
hdrs = hdrs,
140163
app = app,
141164
beam = [":test_beam_files"],
142165
priv = native.glob(["priv/**/*"]) + extra_priv,
143-
license_files = native.glob(["LICENSE*"]) + extra_license_files,
144-
srcs = srcs,
166+
license_files = native.glob(
167+
["LICENSE*"],
168+
exclude = extra_license_files,
169+
) + extra_license_files,
170+
srcs = hdrs + srcs,
145171
deps = deps + runtime_deps,
146172
visibility = ["//visibility:public"],
147173
testonly = True,

private/source_tree.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ def _impl(ctx):
1919
for dep in deps:
2020
lib_info = dep[ErlangAppInfo]
2121
dep_path = path_join(ctx.label.name, lib_info.app_name)
22-
for src in lib_info.include + lib_info.srcs + lib_info.priv + lib_info.license_files:
22+
for src in lib_info.srcs + lib_info.priv + lib_info.license_files:
2323
rp = additional_file_dest_relative_path(dep.label, src)
2424
dest = ctx.actions.declare_file(path_join(dep_path, rp))
2525
ctx.actions.symlink(output = dest, target_file = src)

0 commit comments

Comments
 (0)