Merge pull request #38 from rabbitmq/rules_erlang-37

HoloRin · web-flow · commit 1c82dc0296d3 · 2022-04-08T17:14:32.000+02:00
Properly quote erlc_opts when passed to erlc in the erlc rule
diff --git a/private/erlc.bzl b/private/erlc.bzl
@@ -109,7 +109,7 @@ def _impl(ctx):
         include_args = " ".join(include_args),
         pa_args = " ".join(pa_args),
         out_dir = dest_dir,
-        erlc_opts = " ".join(ctx.attr.erlc_opts),
+        erlc_opts = " ".join(["'{}'".format(opt) for opt in ctx.attr.erlc_opts]),
     )
 
     inputs = []

Original file line number	Diff line number	Diff line change
`@@ -109,7 +109,7 @@ def _impl(ctx):`
`109`	`109`	`include_args = " ".join(include_args),`
`110`	`110`	`pa_args = " ".join(pa_args),`
`111`	`111`	`out_dir = dest_dir,`
`112`		`- erlc_opts = " ".join(ctx.attr.erlc_opts),`
	`112`	`+ erlc_opts = " ".join(["'{}'".format(opt) for opt in ctx.attr.erlc_opts]),`
`113`	`113`	`)`
`114`	`114`
`115`	`115`	`inputs = []`