-
Notifications
You must be signed in to change notification settings - Fork 734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Azure AD/Entra Documentation #2042
Comments
@iinuwa thank you for taking the time to contribute/provide feedback. You are welcome to continue with the specific changes you have in mind. If we have to edit your changes, that's fine with the members of the core team. Note that you must update both the 4.0 version under Or I can do a couple of these changes where I understand both the intent and where in the docs the changes should be made. It's a good question on whether we can use v1 API URLs for long and what kind of changes would be necessary. @MarcialRosales would know better. |
@iinuwa thank you for providing your feedback and for making contributions. Since the first edition of these instructions on how to configure RabbitMq with Azure/Entra, RabbitMQ has introduced a few changes which makes OAuth2's configuration simpler. You only need to configure the You will not need to configure |
Thanks for looking into this!
Azure AD has an opinion here, unfortunately, as it does not accept the (Regarding deprecation of the v1 endpoints: Microsoft has not announced any formal deprecation, though support sites have been ever since their original libraries for interacting with OAuth2 were deprecated back in Dec 2022. Whenever Microsoft does announce deprecation, we'll need to add a parameter to not set the |
You are right that we need to do something about the |
Ah, I see; yes, that makes sense.
Yeah, Microsoft is throwing around their weight by adding slight tweaks to the OAuth spec that makes just different enough not to work for many generic client implementations. Unfortunately, they're big enough that clients just have to workaround it. Thanks again for looking into it! I'm happy to test the resource parameter config whenever you get around to it. |
Is your feature request related to a problem? Please describe.
Thanks for a great project!
Getting RabbitMQ set up with Azure in the way that I'd like took a lot of work to understand and get working correctly. I ran into a few issues I ran into (on RabbitMQ 3.13.7), that I think could have been avoided with documentation changes, so I thought I'd share. (I created PRs for some other doc changes, but these may be more extensive/intentional, so I'm creating an issue instead.
Describe the solution you'd like
v2.0
in a few places (for the OIdC metadata URL and JWKS URI), but silently uses v1 for the issuer/authorize endpoint. This is actually required for management login, since the setup will not work with the v2.0 authorize endpoint, as RabbitMQ adds theresource
parameter to the authorize URL, which will throwAADSTS901002: The 'resource' request parameter isn't supported.
on the v2.0 authorize endpoint. It would be best to make all of the URLs point to the v1 endpoints (https://login.microsoftonline.com/{tenant-id} for the issuer and https://login.microsoftonline.com/common/discovery/keys for the JWKS URI), and add an explicit warning that says that v1 endpoints are required, mentioning the above Azure error code so that it can be easily searched.identifierUris
property in the manifest to whatever value they want to set theresource_server_id
to.)scope_prefix
to an empty stringauth_oauth2.scope_prefix = ""
; it didn't seem to recognize my claims when I set it that way. I decided to set it torabbitmq.
so that I could use the same values across multiple different Azure AD applications without having to inject the client_id (which does not exist until the Azure AD application is created.) (Similar problem to Enable use different identifier of role id and resource id in OAuth flow rabbitmq-server#7861.) I guess this isn't really actionable without more data, but just thought I'd mention it anyway.Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: