Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugins could determine use of longnames from the global setting #4230

Closed
lukebakken opened this issue Mar 3, 2022 · 0 comments · Fixed by #6410
Closed

Plugins could determine use of longnames from the global setting #4230

lukebakken opened this issue Mar 3, 2022 · 0 comments · Fixed by #6410
Assignees
@lukebakken
Milestone
3.12.0

Comments

@lukebakken
Copy link
Collaborator

See the following:

rabbitmq/rabbitmq-website#1366
#4229

The Consul peer discovery plugin requires that a user set cluster_formation.consul.use_longname even though that could be determined by calling rabbit_nodes:name_type/0.

There may be other places that could be updated to use the global setting. This would help users out in that they wouldn't have to set "the same thing" in two places.
@lukebakken lukebakken self-assigned this Oct 25, 2022
SimonUnge added a commit to SimonUnge/rabbitmq-server that referenced this issue Nov 10, 2022
@SimonUnge
See rabbitmq#4230. peer_discovery_consul to use global setting for lo…
89636c1 
…ng/short nodename
@lukebakken lukebakken mentioned this issue Nov 10, 2022
Merged
12 tasks
lukebakken pushed a commit to SimonUnge/rabbitmq-server that referenced this issue Nov 10, 2022
@SimonUnge @lukebakken
Fixes rabbitmq#4230
808c303 
peer_discovery_consul to use global setting for long/short nodename
@michaelklishin michaelklishin modified the milestones: 3.11.4, 3.12.0 Nov 10, 2022
SimonUnge added a commit to SimonUnge/rabbitmq-server that referenced this issue Nov 10, 2022
@SimonUnge
See rabbitmq#4230. Restore schema config for backwards compat
ba52e93
michaelklishin added a commit that referenced this issue Nov 11, 2022
@michaelklishin
Merge pull request #6410 from SimonUnge/simunge/4230_use-global-longn…
149a893 
…ame-settings

See #4230. peer_discovery_consul to use global setting for long/short…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukebakken lukebakken

Labels
None yet
Projects
None yet
Milestone
3.12.0
Development

Successfully merging a pull request may close this issue.

See #4230. peer_discovery_consul to use global setting for long/short… SimonUnge/rabbitmq-server
2 participants
@michaelklishin @lukebakken