Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken swipe actions #32

Open
denis-obukhov opened this issue Nov 30, 2020 · 1 comment
Open

Broken swipe actions #32

denis-obukhov opened this issue Nov 30, 2020 · 1 comment

Comments

@denis-obukhov
Copy link

Checklist

  • [x ] This is not a Apple's bug.
  • [x ] Reviewed the README and documents.
  • [x ] Searched existing issues for ensure not duplicated.

Expected Behavior

trailingSwipeActionsConfigurationForRowAt is called

Current Behavior

trailingSwipeActionsConfigurationForRowAt not called

Steps to Reproduce

  1. Create table view with diffable data source
  2. Implement table view delegate's method tableView( tableView: UITableView, trailingSwipeActionsConfigurationForRowAt indexPath: IndexPath)_
    )
  3. Set data source to diffable data source and delegate to self.
  4. See that it's not called

Environments

  • version:
    0.4.0
  • Swift version:
    5.2
  • iOS version:
    14.2
  • Xcode version:
    12.2
  • Devices/Simulators:
    iPhone 7/iPhone 11 Pro
  • CocoaPods/Carthage version:
    0.4.0
@mateuszSawa
Copy link

mateuszSawa commented Jul 8, 2022

@denis-obukhov quick fix for it:

class SwipeTableViewDiffableDataSource<SectionIdentifierType: Hashable, ItemIdentifierType: Hashable>: TableViewDiffableDataSource<SectionIdentifierType, ItemIdentifierType> { override func tableView(_ tableView: UITableView, canEditRowAt: IndexPath) -> Bool { return true } }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants