Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling #39

Open
Tracked by #27
aleksanderbl29 opened this issue Nov 27, 2024 · 3 comments
Open
Tracked by #27

Improve error handling #39

aleksanderbl29 opened this issue Nov 27, 2024 · 3 comments

Comments

@aleksanderbl29
Copy link
Collaborator

aleksanderbl29 commented Nov 27, 2024

I would like to add more informative error messages with clear instructions on what to do or where to find your error.

Especially the error in #22 needs fixing

@aleksanderbl29 aleksanderbl29 mentioned this issue Nov 27, 2024
16 tasks
@aleksanderbl29
Copy link
Collaborator Author

When trying to reproduce #24 i get this error

> dst_get_data(table = 'FV22TOTA', VALRES='*', OMRÅDE='*', Tid='*')
Error in dst_get_data(table = "FV22TOTA", VALRES = "*", OMRÅDE = "*",  : 
  {"errorTypeCode":"REQUEST-LIMIT","message":"Forespørgslen på op mod 6.224.652 celler er over begrænsningen på 1.000.000 celler for denne filtype. Anvend BULK eller andet streaming format i stedet."}

Would be nice to extract the message and tell the user that they should use "bulk" format

@aleksanderbl29
Copy link
Collaborator Author

With 8cb79e5 we now properly parse the error message and returns it directly to the user in the language specified.

@aleksanderbl29
Copy link
Collaborator Author

When trying to reproduce #24 i get this error

> dst_get_data(table = 'FV22TOTA', VALRES='*', OMRÅDE='*', Tid='*')
Error in dst_get_data(table = "FV22TOTA", VALRES = "*", OMRÅDE = "*",  : 
  {"errorTypeCode":"REQUEST-LIMIT","message":"Forespørgslen på op mod 6.224.652 celler er over begrænsningen på 1.000.000 celler for denne filtype. Anvend BULK eller andet streaming format i stedet."}

Would be nice to extract the message and tell the user that they should use "bulk" format

This has now been fixed with 8cb79e5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant