-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In mode = "view", could tm_credits use leaflet::addTiles()
#806
Comments
leaflet::addTiles()
leaflet::addTiles()
Good point, this should be done in v4. In R-leaflet, the attributions are collected via the <div class="leaflet-bottom leaflet-right">
<div class="leaflet-control-attribution leaflet-control">
<a href="https://leafletjs.com" title="A JS library for interactive maps">Leaflet</a> | Attribution A | Attribution B
</div>
</div> So in tmap we could collect all the tm_credits text, concatenate to addTiles(urlTemplate = "", attribution = credits_text) However, ideally, I would like to have more control of this attribution text via a function like |
Nope, no idea |
Implemented, but I'd like your opinions about the defaults @olivroy and @Nowosad Without tm_shape(world) + tm_polygons() With tm_shape(world) + tm_polygons() + tm_credits("My attribution text") Without arguments: tm_shape(world) + tm_polygons() + tm_credits() Two issues/questions:
|
This is great, thanks for implementing! I like the defaults you implemented.
I don't have strong feelings, maybe wait for FR and keep it simple for now? Maybe with an
The original credits are not essential to the map imo, but I wouldn't know the legal / copyright implications. I'd rather not see them by default on static maps with basemaps, but no strong feelings |
leaflet::addTiles()
leaflet::addTiles()
I sometimes use (in v3)
Could this be equivalent as
Thanks
Apologies if this already exists in v4. I just wanted to type it quickly.
The text was updated successfully, but these errors were encountered: