Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git_default_branch_rename() could attempt to set the codecov default too? (or give the user an AI to do so) #2078

Open
MichaelChirico opened this issue Oct 25, 2024 · 1 comment
Labels
git git, GitHub, and CI in general tidy-dev-day 🤓 Tidyverse Developer Day

Comments

@MichaelChirico
Copy link
Contributor

Just encountered this:

r-lib/bit64#104

I was able to update master->main as the default branch in git, but Codecov does not automatically pick up these changes (so that when you browse to the repo on Codecov, it looks like coverage has not changed since the last commit to the old master). It took several days to notice that this is wrong.

Therefore it would be nice if this function could also work to update codecov/inform codecov of the change.

It might be overkill to add codecov API support from scratch if there's nothing using that so far in {usethis}. In that case, just writing something in the console like "Don't forget to manually update the default branch in Codecov, follow these steps" would still be good, ideally after detecting that {covr} is used for this repo.

@jennybc
Copy link
Member

jennybc commented Jan 31, 2025

Based on my very frustrating interactions with Codecov in the browser, I have zero appetite for attempting to configure this.

But this suggestion is morally similar to stuff we are already doing in report_fishy_files():

report_fishy_files(old_name = old_local_db, new_name = to)

We could emit some sort of nudge if it looks like Codecov is in use.

@jennybc jennybc added git git, GitHub, and CI in general tidy-dev-day 🤓 Tidyverse Developer Day labels Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
git git, GitHub, and CI in general tidy-dev-day 🤓 Tidyverse Developer Day
Projects
None yet
Development

No branches or pull requests

2 participants