-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When building articles with duplicate chunk names, error stack trace does not include the actual Rmarkdown parsing error #2786
Comments
Agree we should surface this error (and wondering what other similar errors we are not surfacing) but I'm not sure how to do that when the call is wrapped in |
Hmmmm, when I add that vignette to pkgdown and call
|
Hmm that's strange. I am on R version 4.3.0
If the issue is rooted in an "outdated" version of one of those, that implies that potentially a bump in the required version of the package at fault would fix it. Just looking at the options alongside the stack trace and source code for I can push my latest package version to its repo (https://github.com/fwimp/ohvbd/) and provide instructions here on how to reproduce the exact issue as I originally discovered it (by renaming a chunk in a vignette), just in case the issue stems somehow from my particular package (though I'm not doing anything particularly obscure with my vignettes). Would that be helpful? |
Right, I've confirmed that updating rlang to v1.1.4 causes the error to appropriately be propagated up to the user:
I expect this was fixed in this commit r-lib/rlang@84deb87, as I can't see anything else in the commits making up 1.1.3 and 1.1.4 for rlang that would potentially intersect with this issue. Doesn't really matter in any case as it seems like updating rlang solves the problem. I guess if this is something that shouldn't happen for users, then bumping the version requirement for pkgdown to |
Yeah, we should just bump the required rlang version just to make sure that no one else experiences this. Thanks for the investigation! |
When trying to build a vignette that contains duplicate chunk labels,
build_site()
does not give any real indication of where the problem originated.The full
.Last.error
There is also nothing in
.Last.error$stdout
or.Last.error$stderr
to indicate where this might be going wrong.The data that is required is however present in
.Last.error$parent$parent$message
Whilst not essential, including this data in the error output would make it much easier to track down these sorts of bugs in situations where the vignette is hard to get to knit standalone.
Reprex vignette file
The text was updated successfully, but these errors were encountered: