Only use hack when needed

Author: jeroen

R/url.R

@@ -282,9 +282,11 @@ url_build <- function(url) {
   # curl url parser esacapes colons in paths which google seems to use
   # quite frequently. So we hack the problem away for now, restoring the
   # behaviour of httr2 1.1.2
-  path <- curl::curl_parse_url(url, decode = FALSE)$path
-  path <- gsub("%3A", ":", path)
-  curl::curl_modify_url(url, path = I(path))
+  if (grepl("%3A", url, fixed = TRUE)) {
+    path <- curl::curl_parse_url(url, decode = FALSE)$path
+    path <- gsub("%3A", ":", path, fixed = TRUE)
+    curl::curl_modify_url(url, path = I(path))
+  }
 }
 
 #' Parse query parameters and/or build a string

tests/testthat/test-url.R

@@ -103,8 +103,8 @@ test_that("encodes params and paths", {
 
 test_that("colons in paths are left as is", {
   expect_equal(
-    url_modify("https://example.com", path = "a:b"),
-    "https://example.com/a:b"
+    url_modify("https://example.com", path = "a:b/foo bar/"),
+    "https://example.com/a:b/foo%20bar/"
   )
 })