Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling gert::git_conflicts() crashes R when renamed files contain conflicts #229

Open
olivroy opened this issue Jul 12, 2024 · 2 comments

Comments

@olivroy
Copy link
Contributor

olivroy commented Jul 12, 2024

Not sure why, but it works fine when only simple git conflicts happen. (when a git conflicts involves a renamed file)

@jeroen
Copy link
Member

jeroen commented Jul 12, 2024 via email

@olivroy
Copy link
Contributor Author

olivroy commented Jul 12, 2024

It is a bit difficult to simulate a git conflict.

But basically, if I use usethis::pr_merge_main() and I say I want to merge conflicts.

and if a file involved has been renamed.

Possibly the easiest way for you to simulate would be to add something to commit somethign to gert NEWS file on main.

Afterwards, you can use

usethis::pr_fetch(209)
usethis::pr_merge_main()
# Say you want to resolve merge conflicts

To reproduce, you just have to call gert::git_conflicts() in the console.

I use RStudio. I don't know if this is related.

@olivroy olivroy changed the title Calling gert::git_conflicts() crashes R when renaming occured Calling gert::git_conflicts() crashes R when renamed files contain conflicts Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants