Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using jsonb instead of hstore #27

Open
posikifi opened this issue May 5, 2021 · 3 comments
Open

Using jsonb instead of hstore #27

posikifi opened this issue May 5, 2021 · 3 comments

Comments

@posikifi
Copy link

posikifi commented May 5, 2021

Hi!

This is maybe suggestion and/or question: is it possible to change storage of audit-tables from hstore to jsonb?

Pros

  • jsonb is part of core PostgreSQL, hstore still needs extension
  • jsonb is newer has more functionalities (?)

Cons

  • It work, no need to change
  • plugin need modification

Peformance: there is a lot of discussion about this, but I haven't seen permanent answer. It depends.

P

@haubourg
Copy link
Contributor

haubourg commented May 5, 2021

I agree and the upstream pg_audit has been abandoned and switched to jsonb logic.
To me it is essentially a matter of funding. I could be interested in supporting a part of it if efforts can be merged. This tool can really be helpful in many applications!

cc @vpicavet @ponceta please gather other potential funders / contributors here if you hear of some interest.

@posikifi
Copy link
Author

posikifi commented May 6, 2021

I also suggest that we will include/merge https://gitlab.com/Oslandia/audit_trigger into this project.

Another suggestion is that we rename audit_trigger to history_trigger (or something). Reasoning: pgAudit is more auditing (including select etc.) and it has totally different scope.

I can use some time for this and is external funding is needed, let's see what we can do.

@lbartoletti
Copy link
Contributor

@posikifi There is (was) a PR for this purpose https://gitlab.com/Oslandia/audit_trigger/-/merge_requests/2/diffs

It takes a little time to update and test, but I know this was discussed a few years ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants