Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SHA checking #25

Merged
merged 10 commits into from
Aug 23, 2023
Merged

Implement SHA checking #25

merged 10 commits into from
Aug 23, 2023

Conversation

alanocallaghan
Copy link
Contributor

This requires javaFX 20 to use flatMap bindings.

@petebankhead
Copy link
Member

Hmmm, QuPath v0.4.x only has JavaFX 19 though and we need compatibility with it.

@alanocallaghan
Copy link
Contributor Author

alanocallaghan commented Aug 22, 2023

Actually, it seems to work okay on 19. Can you check?

Download button should be disabled if we select a model that's been previously downloaded, or after we download the model.

@petebankhead petebankhead merged commit b3b4076 into main Aug 23, 2023
1 check passed
@petebankhead petebankhead deleted the download-sha branch August 23, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants