Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode extension crashes the extension host at extension activation #1182

Closed
schl3ck opened this issue Jan 11, 2024 · 5 comments
Closed

VSCode extension crashes the extension host at extension activation #1182

schl3ck opened this issue Jan 11, 2024 · 5 comments
Assignees
Labels
false positive Severe bug: quick-lint-js rejects valid code
Milestone

Comments

@schl3ck
Copy link

schl3ck commented Jan 11, 2024

When the extension is activated the extension host immediately crashes. It doesn't matter what .js file I've open.

The only clue I found was in the developer tools of VSCode. All other output views did not provide any useful information. In the console of the developer tools it logged:

D:/a/quick-lint-js/quick-lint-js/src/quick-lint-js/io/file-canonical.cpp:676: internal check failed in resolve_symlink: false
quick-lint-js crashed. Please report this bug here:
https://quick-lint-js.com/crash-report/

Please let me know if there is any other information I can provide.

@strager
Copy link
Collaborator

strager commented Jan 12, 2024

Thanks for the bug report. I'll try to reproduce the issue this weekend.

@strager strager self-assigned this Jan 12, 2024
@strager strager added the false positive Severe bug: quick-lint-js rejects valid code label Jan 12, 2024
@strager
Copy link
Collaborator

strager commented Jan 15, 2024

I can reproduce the issue if I create a directory junction and open a file through that junction. For example:

mklink /j p:\quick-lint-js-sandbox p:\quick-lint-js\sandbox
code p:\quick-lint-js-sandbox\hello.js

I could not reproduce this issue when using subst or a network drive.

@schl3ck Are you using a junction/symlink?

@schl3ck
Copy link
Author

schl3ck commented Jan 18, 2024

Yes, I'm editing the files through a junction.

@strager strager added this to the 3.2 milestone Jan 21, 2024
@strager
Copy link
Collaborator

strager commented Feb 17, 2024

Fixed in Git commit 748b775. This fix will be included in quick-lint-js version 3.2.

@strager strager closed this as completed Feb 17, 2024
@strager
Copy link
Collaborator

strager commented Mar 4, 2024

Fix released in version 3.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
false positive Severe bug: quick-lint-js rejects valid code
Projects
None yet
Development

No branches or pull requests

2 participants