fix: faulty use of set.difference()

Author: janbritz

questionpy_sdk/_package/_validate.py

@@ -138,28 +138,30 @@ def validate_package_name_and_description(manifest: Manifest) -> None:
     name_translations = set(manifest.name.keys())
     description_translations = set(manifest.description.keys())
 
-    if missing_name_translations := name_translations.difference(declared_translations):
+    if missing_name_translations := declared_translations - name_translations:
         missing_translations_list = "\n\t- " + "\n\t- ".join(missing_name_translations)
         _log.warning("The following package name translations are missing:%s", missing_translations_list)
 
-    if unused_name_translations := declared_translations.difference(name_translations):
+    if unused_name_translations := name_translations - declared_translations:
         unused_translations_list = "\n\t- " + "\n\t- ".join(unused_name_translations)
         _log.warning(
             "The following package name translations are given but missing in the languages list:%s",
             unused_translations_list,
         )
 
     if description_translations:
-        if missing_description_translations := description_translations.difference(declared_translations):
+        if missing_description_translations := declared_translations - description_translations:
             missing_translations_list = "\n\t- " + "\n\t- ".join(missing_description_translations)
-            _log.warning("The following package description translations are missing:%s", missing_translations_list)
+            message = "The following package description translations are missing:%s"
 
-        if unused_description_translations := declared_translations.difference(description_translations):
-            unused_translations_list = "\n\t- " + "\n\t- ".join(unused_description_translations)
-            message = "The following package description translations are given but missing in the languages list:%s"
-            if Bcp47LanguageTag("en") in unused_description_translations:
+            if Bcp47LanguageTag("en") in missing_translations_list:
                 message += "\nThe package description should be available in English as it is used as a fallback."
+
+            _log.warning(message, missing_translations_list)
+
+        if unused_description_translations := description_translations - declared_translations:
+            unused_translations_list = "\n\t- " + "\n\t- ".join(unused_description_translations)
             _log.warning(
-                message,
+                "The following package description translations are given but missing in the languages list:%s",
                 unused_translations_list,
             )

tests/questionpy_sdk/package/test_validate.py

@@ -106,6 +106,7 @@ def test_warn_when_name_translations_are_missing(manifest: Manifest, caplog: Log
 
     warn_messages = get_warnings(caplog)
     assert len(warn_messages) == 1
+    assert "translations are missing" in warn_messages[0]
     assert "- de" in warn_messages[0]
     assert "- en" not in warn_messages[0]
 
@@ -119,6 +120,7 @@ def test_warn_when_description_translations_are_missing(manifest: Manifest, capl
 
     warn_messages = get_warnings(caplog)
     assert len(warn_messages) == 1
+    assert "translations are missing" in warn_messages[0]
     assert "- de" in warn_messages[0]
     assert "- en" not in warn_messages[0]
 
@@ -131,6 +133,7 @@ def test_warn_when_name_translation_is_give_in_missing_language(manifest: Manife
 
     warn_messages = get_warnings(caplog)
     assert len(warn_messages) == 1
+    assert "translations are given but missing" in warn_messages[0]
     assert "- de" in warn_messages[0]
     assert "- en" not in warn_messages[0]
 
@@ -146,6 +149,7 @@ def test_warn_when_description_translation_is_give_in_missing_language(
 
     warn_messages = get_warnings(caplog)
     assert len(warn_messages) == 1
+    assert "translations are given but missing" in warn_messages[0]
     assert "- de" in warn_messages[0]
     assert "- en" not in warn_messages[0]
 
@@ -159,4 +163,5 @@ def test_warn_when_description_is_given_but_not_in_english(manifest: Manifest, c
 
     warn_messages = get_warnings(caplog)
     assert len(warn_messages) == 1
+    assert "translations are missing" in warn_messages[0]
     assert "description should be available in English" in warn_messages[0]