Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs for missing values #306

Open
baggepinnen opened this issue May 15, 2020 · 1 comment
Open

Docs for missing values #306

baggepinnen opened this issue May 15, 2020 · 1 comment

Comments

@baggepinnen
Copy link

I got confused by the following query

metrics = @from i in data0 begin
    @where i.happy != "NA" && i.energetic != "NA" && !ismissing(i.ActualStartTime)
    @select {i.ParticipantID, happy=round(Int, i.happy), energy=round(Int, i.energetic), i.sex, time=i.ActualStartTime}
    @collect DataFrame
end

and I expected the resulting dataframe to not contain any records for which time is missing, but no filtering took place. I had it explained for me on Zulip, that missing are translated to DataValues. The docs https://www.queryverse.org/Query.jl/stable/gettingstarted/#Missing-values-1
are not super clear on this and I did not expect this behavior even after having read that part of the docs again. In particular, the docs do not really mention what to use instead of ismissing or how I can opt out of the automatic translation if it all possible.

@Paethon
Copy link

Paethon commented Jun 16, 2020

This DataValue instead of missing business has confused me as well. Especially since I think there is no explanation in the documentation why the package is not using the standard Julia missing type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants